New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): ✨ added method to verify header in apiResponse c… #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WasiqB
requested changes
Jun 17, 2022
core-java/src/main/java/com/github/wasiqb/boyka/builders/ApiResponse.java
Outdated
Show resolved
Hide resolved
Hi @MakodeAjay could you please sign your commits. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
@mfaisalkhatri sign my commits. |
@MakodeAjay , please sign the CLA from the link shared by @CLAassistant in above comments. |
WasiqB
requested changes
Jun 18, 2022
core-java/src/main/java/com/github/wasiqb/boyka/builders/ApiResponse.java
Outdated
Show resolved
Hide resolved
WasiqB
approved these changes
Jun 18, 2022
@MakodeAjay , please raise a new PR with signed commits. |
WasiqB
added
🚀 pr: new feature
PR which introduces new features
and removed
🚀 pr: new feature
PR which introduces new features
labels
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #53
Type of changes?
Checklist for Java project
Checklist for Website
Reviewers
@WasiqBhamla/boyka-core