Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ added method to verify header in apiResponse c… #87

Closed
wants to merge 4 commits into from

Conversation

MakodeAjay
Copy link
Contributor

@MakodeAjay MakodeAjay commented Jun 17, 2022

Closes: #53

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB linked an issue Jun 17, 2022 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022

CLA assistant check
All committers have signed the CLA.

@MakodeAjay MakodeAjay marked this pull request as ready for review June 17, 2022 17:40
@MakodeAjay MakodeAjay requested a review from a team as a code owner June 17, 2022 17:40
@MakodeAjay MakodeAjay requested a review from WasiqB June 17, 2022 17:40
@mfaisalkhatri
Copy link
Contributor

Hi @MakodeAjay could you please sign your commits.
Refer the following link to know more about signing commits.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@MakodeAjay
Copy link
Contributor Author

@mfaisalkhatri sign my commits.

@WasiqB
Copy link
Member

WasiqB commented Jun 18, 2022

@MakodeAjay , please sign the CLA from the link shared by @CLAassistant in above comments.

@WasiqB
Copy link
Member

WasiqB commented Jun 18, 2022

@MakodeAjay , please raise a new PR with signed commits.

@WasiqB WasiqB closed this Jun 18, 2022
@WasiqB WasiqB added 🚀 pr: new feature PR which introduces new features and removed 🚀 pr: new feature PR which introduces new features labels Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Add assertion method for response headers
4 participants