Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataType naming with suffix _t #193

Closed
howjmay opened this issue Mar 6, 2019 · 6 comments
Closed

dataType naming with suffix _t #193

howjmay opened this issue Mar 6, 2019 · 6 comments

Comments

@howjmay
Copy link
Contributor

howjmay commented Mar 6, 2019

To make dataTypes and variables naming more flexible, should we add suffix _t?
i.e. from stack to stack_t, from ModuleInst to ModduleInst_t
@yuhao-kuo
Copy link
Member

將 suffix 使用在基本的 type / structure 中，用這個方式來區分基本的 type / structure 和 WasmVM 元件 也許會比較直觀。

@howjmay
Copy link
Contributor Author

howjmay commented Mar 7, 2019

要改嗎？

@yanjiuntw
Copy link
Member

我覺得可以改，我剛開始加入的時候，閱讀程式碼也很容易搞混。

@LuisHsu
Copy link
Collaborator

LuisHsu commented Mar 12, 2019

我覺得OK，各個大寫開頭的 structure 會保留大寫，不過小寫開頭的像 queue, vector, stack 之類的會加 suffix

@LuisHsu LuisHsu mentioned this issue May 30, 2019
Closed
@LuisHsu
Copy link
Collaborator

LuisHsu commented Jun 4, 2019 •
edited
Loading

我在整裡的時候發現用 _t 會和 OS 裡的 stack_t 撞到，所以改用 _p
反正也封裝成 opaque pointer 了

@LuisHsu
Copy link
Collaborator

LuisHsu commented Jun 11, 2019

#222

@LuisHsu LuisHsu closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LuisHsu @yuhao-kuo @howjmay @yanjiuntw