Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default time in force integration #110

Closed
marinlauber opened this issue Feb 28, 2024 · 3 comments
Closed

Change default time in force integration #110

marinlauber opened this issue Feb 28, 2024 · 3 comments

Comments

@marinlauber
Copy link
Member

In the pressure force integration the default is to use t=0 for the body position, but this doesn't correspond to the pressure, which is stored at time(sim).

I think the default behavior should be to measure the body at time(sim), where the pressure is also defined. This would require passing sim or flow directly to the function.

@b-fg
Copy link
Member

b-fg commented Feb 28, 2024

Sure, make a PR and I will review it :)

@weymouth
Copy link
Collaborator

Did this get done?

@marinlauber
Copy link
Member Author

No, I haven't done it. I am not sure how to pass the correct time to the function without changing the function arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants