Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoreboard. Error after player respawn. Sponge. #212

Closed
SawFowl opened this issue Mar 1, 2018 · 7 comments
Closed

Scoreboard. Error after player respawn. Sponge. #212

SawFowl opened this issue Mar 1, 2018 · 7 comments

Comments

@SawFowl
Copy link

SawFowl commented Mar 1, 2018

I use a static Scoreboard with automatic update of values on the timer. I'm using a server with Sponge API.

After respawn, when the scoreboard is updated, player is thrown from the server, and the following error appears in the BungeeCord console.
https://pastebin.com/kf6UppCz
If you connect directly to the Sponge server (without using WaterFall), then the problem does not arise.

@MarkL4YG
Copy link

MarkL4YG commented Mar 2, 2018

Did you check wether or not this happens in BungeeCord too? If so you'd report to them instead.

@SawFowl
Copy link
Author

SawFowl commented Mar 2, 2018

I reported, but they refused to correct it.
SpigotMC/BungeeCord#2366
I hope that at least your team will fix. The original BungeeCord also does not allow you to connect to Forge servers, and you implemented it.

@electronicboy
Copy link
Member

Bungeecord, and by extension Waterfall, requires tracking stuff like scoreboards properly, your issue here is that you're redefining an objective that already exists, although the objective doesn't exist on the new server until you're creating it, you're sending it while to the client the existing version is still defined, as bungeecord hasn't been able to clean that up yet.

It's not really possible to fix this here (Bungeecord needs to be able to handle cases where they didn't connect to the new server, removing objectives too early would cause a crash should the server send data for objectives that don't exist).

I would suggest adding some random text to the objective name internally so that you can ensure that they don't match up across server instances.

@SawFowl
Copy link
Author

SawFowl commented Mar 2, 2018

I can make a random name for the scoreboard, but in this case I get a memory leak. Thanks for the info.

@MarkL4YG
Copy link

MarkL4YG commented Mar 2, 2018

I'd recommend naming scoreboards using uuids in this case.
As for the memory leaks: Maybe you can find a way to destroy the old scoreboard objects when a player respawns.

@SawFowl
Copy link
Author

SawFowl commented Mar 2, 2018

If I had found a way to delete the old values of the scoreboard, I would not have to write here.

@MarkL4YG
Copy link

MarkL4YG commented Mar 2, 2018

Reporting an issue does not require you to not have a work-around. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants