[G5.0.2] Download does not appear in download window of browser

[mkueno]

What happened?

When downloading, the download window opens but the download do not appear in this window. Must go to downloads folder in Win10 to access downloads. This bug only appears in G5.0.2, this does not appear in G5.0.1

Reproducible?

• I have tested this on Firefox.

Version

Other

What platform are you seeing the problem on?

Windows

Relevant log output

No response

[lyrnya]

Me too

[rdraconis]

I do not have the capability of downgrading to G5.0.1 to test whether the Downloads window works properly (the installer is not included in Waterfox's version history CDN @ https://cdn.waterfox.net/releases/win64/installer/ ) ... but, I can confirm this is happening to me on G5.0.2, too.

When I tried to download the latest nVidia drivers this morning, the download icon next to the search bar in the main browser UI turned into a checkmark to indicate the file was done downloading, but when I clicked on it, it only shows "No downloads for this session" and "Show all downloads." Clicking "Show all downloads" pulls up the Library window, but the list of downloads on the right, where there is usually months' worth of old downloads, is completely blank. Right-clicking within this empty space pulls up the usual right-click menu, but nearly all options are clickable, including all of the options between "Pause" and "Show in folder," as well as "Delete" and "Remove from history." There is no response from Waterfox when I click any of these available options. Additionally, in the Library window's left-most panel, the "History" and "All Bookmarks" sections work normally, and they display their contents in the right-most window panel normally.

I have tried using Waterfox's ability to clear all browsing & download history for all time, but that sadly didn't fix it. I also tried to add an about:config setting, "browser.Download.useToolkitUI", and toggling it to both True and False, but that didn't change anything -- apparently that was a troubleshooting step that disappeared ~8 years ago. Additionally, I also tried running Waterfox in Safe Mode, with all addons disabled, and switched to a different theme (light instead of dark, both built-in themes), but alas, no change.

It would appear that the Downloads window UI is bugged. The files do download correctly, but I have to navigate Win10's File Explorer to my Downloads folder (or whatever folder I save the files to) in order to get to the files.

[UmiAkai]

I have the same issue on my win10 laptop, however my win7 desktop with G5.0.2 works just fine.

[rdraconis]

Following up after @UmiAkai 's comment, I checked in with a pair of laptops, one running Windows 10, and an old one running Windows 7 -- both running Waterfox G5.0.2.

The Windows 10 laptop has the problems described above -- a non-functioning Downloads section of the Library window, and clicking the download icon in the toolbar next to the searchbox only shows "No downloads for this session" and "Show all downloads."

However, the Windows 7 laptop's Library -> Downloads section works properly -- and clicking on the download icon in the toolbar next to the searchbox shows the list of recent downloads as normal.

Very intriguing!

[orazdow]

Same for me on Linux Mint. I downloaded an .m3u8, but the downloads window says "no downloads for this session"

[feelingwalnut]

also on debian bookworm with the same issue, worked before an update or two ago, doesnt work now.
didnt try a profile refresh or clean install.
did try other themes (default themes)
also tried security settings (remember history)

no differences.

[WisteriaSp]

Facing the same issue on G5.0.2 running on Windows 10.

[mkueno]

Downloaded and installed G5.1. This version has the same issue with the download not appearing in the download window

[rdraconis]

I went ahead and upgraded to G5.1, and can confirm the download button & window still don't work properly. I did manage to find a link to the G5.0.1 installer ( https://cdn1.waterfox.net/waterfox/releases/G5.0.1/WINNT_x86_64/Waterfox%20Setup%20G5.0.1.exe ) and downgraded to that release, and the download window & button are working normally again. I will stick to G5.0.1 until I learn this issue is fixed.

[feelingwalnut]

so got time to play with this.
if you "refresh waterfox" it should resolve the issue.
5.1 worked fine as a fresh install on wine, 5.0.1 also worked
5.1 upgrade on linux also works but only after "refresh waterfox"

i'm not sure yet if a surgical solution exists. IE remove a single file or make an edit VS what amounts to trashing a profile.

restoring the old profile brings the issue back
believe it is narrowed down to something in prefs.js

accidentally deleted my original prefs.js file, after an hour of editing about:config and then restoring the file it was bound to happen i'd "move" instead of "copy"
but it is alphabetical and i believe one of the items between browser.tabs.copyurl and browser.uiCustomication.state are responsible for this issue.

[rdraconis]

@feelingwalnut Thank you for your work and dedication! After backing up my extensions, I went ahead & did a refresh. This did fix the Download button/window. After much extension installing & individual testing, I can confirm it wasn't any of my extensions. I'm thinking along the same lines as you, that something in my years-old Waterfox profiles (possibly a prefs.js setting) clashed with 5.0.2+.

[feelingwalnut]

browser.tabs.selectedTabPrivate
is the responsible prefs.js entry.
if you go into about:config and simply hit the "undo" next to it, it will return it to default and on restarting the browser your downloads will show again. either that or just toggle it to false.
it appears if you close browser with a private tab, this option may get hung.

i have had two situations where it will either toggle or simply disappear from my about:config only to return as false on a restart.
it seems related to #2858 and lines up as far as when the issue began presenting as well as the code implementing that setting entry.