Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G6.0.5: Tab crashes on certain html files #3254

Closed
1 task done
Mikhail-M12 opened this issue Oct 30, 2023 · 8 comments
Closed
1 task done

G6.0.5: Tab crashes on certain html files #3254

Mikhail-M12 opened this issue Oct 30, 2023 · 8 comments
Labels
bug

Comments

@Mikhail-M12
Copy link

What happened?

G6.0.5 can't open certain html files (created by SingleFile addon). Example:
Tier List Maker for Everything - TierMaker (2023-10-28 9_41_23 PM).zip
Tab crashes.

Firefox 115.4.0 opens this file normally.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

G6

What platform are you seeing the problem on?

Windows

Relevant log output

No response
@robbely robbely mentioned this issue Oct 30, 2023
Closed
@robbely
Copy link

robbely commented Oct 30, 2023

I'm having the same issue with the similar addon SingleFileZ. Here is what I posted on the addon's github:

If I use SingleFilesZ to save the page from "https://store.steampowered.com/app/1722660/Hamster_on_Rails/" as an example with large gifs, the file appears to save correctly. However if I reload into Waterfox (latest: G6.0.5 based on latest Firefox ESR) I get the Gah Tab Crashed error. (The saved page loads successfully however in the equivalent Firefox ESR release).

I've tried with clean install of Waterfox and not changing any SingleFileZ settings.

If I open the saved page in winrar and delete the 3 large gifs from the images folder the page will then load successfully in Waterfox.

I have tested the saved file on a number of browsers now (including TorBrowser which is also ESR based) and only Waterfox is crashing with the saved file. Does anyone know if there is an about:config setting (or anything else that might be set differently to Waterfox than other Firefox ESR browsers) that might allow more memory in a tab before the tab gives up and crashes?

@cosmoderp
Copy link

cosmoderp commented Nov 2, 2023 •
edited

Was looking around and this bug report seems about right. Although mine is of yet another similar plugin "Save Page WE" I in my case traced it down to a single line large embedded animated GIF file data:image/gif normally a standalone 16mb GIF. When that large single line code is removed from from the html the page loads fine. This same html file loads fine without modification in several other browsers. Also to note that the crash is instant, at least in my case it does not seem to try and load anything.

@robbely
Copy link

robbely commented Nov 2, 2023

This same html file loads fine without modification in several other browsers.

I haven't been able to reproduce the issue in any other browser than Waterfox, so it is definitely something specific to Waterfox.

Also I tried saving a YouTube page normally (not using an addon) and the result when loaded also gives the Gah error (again only in Waterfox).

@cosmoderp
Copy link

So after adding SinglefileZ to test it as well I saw its output is a completely different type of file from "save page we" but it produces the same crash. Saving as a normal complete page with a folder structure does not cause this crash.

Playing around with inspecting and editing the HTML on the sites I can get the crash every time I simply add the link for the large file GIF. I found other large GIF images to test with and got the same results.

Also tried the youtube video page and you are right. It also only crashed on Waterfox but it would be hard to tell if the two are breaking for the same reason cause there are times when both extensions outputs will not crash on waterfox.

@robbely
Copy link

robbely commented Nov 3, 2023

hard to tell if the two are breaking for the same reason cause there are times when both extensions outputs will not crash on waterfox.

It is true the reasons may be different (for instance saving a youtube page doesn't seem to generate any large files like the addons do), but both crashes are Waterfox-only ones (I can't reproduce the crashes in other firefox or chrome flavours), so there is either one or two things broken in Waterfox.

@scherno2000
Copy link

I created a test html file as simple as possible.

<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <meta charset="utf-8"/>
    <title>MyText</title>
  </head>
  <body>
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx<br/>
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx<br/>
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx<br/>
... and so on (approx 41100+ lines) until the file gets bigger than 4194304 bytes 
 </body>
</html>

For me it crashes on files > 4194304 bytes which is 2^22, that hints to me that is some overflow.

@MaskedMudpuppy
Copy link

I have the same issue with large offline twine html games but only with G6 versions of Waterfox. The older G5 versions of Waterfox works fine as well as Firefox and Chrome...

@yokoffing yokoffing mentioned this issue Mar 12, 2024
Closed
4 tasks
@robbely
Copy link

robbely commented Mar 22, 2024

Seems fixed in G6.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MaskedMudpuppy @cosmoderp @Mikhail-M12 @scherno2000 @robbely