Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without Handlebars.js #31

Closed
thapar opened this issue Feb 9, 2014 · 11 comments
Closed

Without Handlebars.js #31

thapar opened this issue Feb 9, 2014 · 11 comments
Labels

Comments

@thapar
Copy link

thapar commented Feb 9, 2014

Firstly, it's sad that such a clever, compact, and powerful script has been left high and dry in other repos, so THANK YOU for maintaining the project!

I do want to inquire about dependencies though. If I just want to use wysihtml5 without having my buttons styled, or other GUI handled for me, is this repo still usable, or is Handlebars.js a definite dependency? The minimalistic dogma of wysihtml5 was a feature that drew me to it over etherpad, and I was hoping to simply implement the core wysihtml5 (along with your advancements) from this repo, if at all possible.

@Waxolunist
Copy link
Owner

Handlebars runtime (only the runtime not the whole thing) is a dependency for the toolbar only. But its only about 3kb more. If you want to use wysihtml5 without all the toolbars and configuration I'd suggest either use the original one or one of the more advanced forks of wysihtml5 providing some 0.4 versions.

This repo only uses the editor as it is.

@thapar
Copy link
Author

thapar commented Feb 10, 2014

I see, thanks for the answer! What advanced wysihtml5 forks are there? I couldn't find any maintained forks without additional dependencies (bootstrap, etc.)

@Waxolunist
Copy link
Owner

They all seem to be maintained. You have to separate between the editor itself and the bootstrap integration. This is a bootstrap integration repository.

@thapar
Copy link
Author

thapar commented Feb 16, 2014

Thanks, I'll have to do some more digging. Would you say separating the bootstrap integration with the basic editor's code is a trivial task? Perhaps the complexity is over my head, but it just seems tightly woven together.

@Waxolunist
Copy link
Owner

The editor is separated from this code. It uses the editor only as a dependency as you can see, the editor itself is not in this repo it is just linked via bower.
I meant you have to separate the integration code and the editor itself in your mind. The code in this repo uses wysihtml5 and does not change it in any way. The editor is NOT dependent on the code in this repo in any way. They are not woven together.

@thapar
Copy link
Author

thapar commented Feb 16, 2014

Then how were you able to add nested list (outline) formatting?

@Waxolunist
Copy link
Owner

As I said, I am just USING the functions of the editor. See for examples https://github.com/Edicy/wysihtml5/tree/master/examples

That is the plain editor as it is without the bootstrap integration.

This repo here uses wysihtml5, but wysithml5 does not use bootstrap3-wysithmlt5-bower (got it?). So you don't have to implement the core wysihtml editor, because it is already implemented. If you want just the core of wysihtml, just head over to either the original editor https://github.com/xing/wysihtml5 or use one of the forks, like mentioned above.

The purpose of this repo is to provide styled buttons for the editor wysihtml5. Its purpose is not to provide an editor.

If you want to know how to execute a command on the editor read the documentation of the editor or dig into the code of this repo. It's just a link with a data-attribute btw (see folder templates).

@thapar
Copy link
Author

thapar commented Feb 17, 2014

I see, so Edicy's github repository added the nested list ability, which then trickled to you as well because of the use of bower?

@Waxolunist
Copy link
Owner

Nested lists are already possible with the original wysihtml5 version by xing, which is not anymore developed.

But do you really understand what a dependency is or a dependency management tool?

@thapar
Copy link
Author

thapar commented Feb 18, 2014

I didn't realize the original wysihtml5 had list nesting ability. That was my confusion, because as per the Issue tracker, it was still an outstanding feature request.

Yes, I'm aware of what dependencies are, and I understand how a management tool would work, although I have not had experience with any (including bower).

Thanks for taking the time to clarify my confusion!

@Waxolunist
Copy link
Owner

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants