Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] set barcodeFormats on Android #10

Closed
BoscoTin opened this issue Dec 5, 2021 · 2 comments
Closed

[Bug] set barcodeFormats on Android #10

BoscoTin opened this issue Dec 5, 2021 · 2 comments

Comments

@BoscoTin
Copy link

BoscoTin commented Dec 5, 2021

Hi, thanks for creating a great package on code scanning. I have tried it on my testing app and found out it works very good except setting formats on Android device.

I set barcodeFormats: [BarcodeFormat.code39, BarcodeFormat.code128, BarcodeFormat.qr_code] to test whether it can scan only the 3 types of code above. In iOS device, it works properly, but Android can only scan the qr_code type, which is the last element specified on barcodeFormats array.

It should due to .setBarcodeFormats in below only set the formats given from the latest call.

https://github.com/Wayaer/fl_mlkit_scanning/blob/697de6f8cc366c476f10885b2e6de99163bdb5be/android/src/main/kotlin/fl/mlkit/scanning/FlMlKitScanningMethodCall.kt#L102-L121

@Wayaer
Copy link
Owner

Wayaer commented Dec 5, 2021

Thank you for your issues.Bugs have been fixed

@BoscoTin
Copy link
Author

BoscoTin commented Dec 7, 2021

Thanks for fixing this. It works perfect now.

@BoscoTin BoscoTin closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants