Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] Mod Interactions -- Blood Magic Dagger Death X Draconic Evolution Undying Module #1861

Closed
Raidobw2 opened this issue Oct 21, 2021 · 7 comments

Comments

@Raidobw2
Copy link

Issue Description:

User report:
"When using the Sacrificial Knife with the Blood Altar from Blood Magic while the Undying Module is installed on an equipped Draconic Evolution Chest Piece, you die instead of being kept alive by the module, which activates, and your entire inventory is deleted except for your inventory. No gravestone is made."

Our modpack dev talked to DE coders and they said this:
"I suspect blood magic is trying to prevent mods from 'saving you' and it's backfiring somehow.
All i do is cancel the death event.
"

I know BM is supposed to kill you as punishment for using the dagger too much, but at the worst you can allow DE's undying (DE always has been overpowered, and it's honestly fine, both your mod and theirs are in almost every modpack).
If this is on your side, I would suggest either that the LP gain is 0 once you don't have any HP or if you want to be evil, give the player your status effect Soul Fray. Just like if they died basically. From a technical point of view, you could consider that they died and got "revived" instantly by Undying Module. I hope that'll help in deciding how to make changes.

Thank you.

We have a report made on DE's side before coming on here:
Draconic-Inc/Draconic-Evolution#1562
You can check that out if you wish, although the info is super similar to here.

Below are versions:
Draconic-Evolution-1.16.5-3.0.16.417-universal.jar
BloodMagic-1.16.4-3.1.5-25.jar (https://www.curseforge.com/minecraft/mc-mods/blood-magic)
gravestone-1.16.5-1.0.7.jar (https://www.curseforge.com/minecraft/mc-mods/gravestone-mod)

No report on Gravestone mod yet, as normally it works just fine.

What happens:

You die and you lose everything but Curios slots.

What you expected to happen:

Not die, and that a gravestone would generate if the player died.

Steps to reproduce:

  1. Wear DE Draconic Armor with Undying Module
  2. Prick your player with Sacrifial Dagger to generate blood
  3. Completely overshoot pricking and attempt to die with it
  4. You die even so DE's armor should prevent it
  5. No Gravestone gets generated, lose stuff

---IMPORTANT---
See the original modpack issue at
FTBTeam/FTB-Modpack-Issues#156
IT CONTAINS SCREENSHOTS within the procedure being executed by our user, step by step.


Affected Versions (Do not use "latest"):

  • BloodMagic: BloodMagic-1.16.4-3.1.5-25.jar
  • Minecraft: 1.16.5
  • Forge: 1.16.5-forge-36.2.8
  • Mod Pack: FTB OceanBlock 1.4.0
@wrincewind
Copy link
Collaborator

Hi, just to check - does this gravestone interaction only happen while wearing draconic armour, or can you replicate it without? We've had a similar issue with the gravestones mod recently, but they didn't mention DE.

@Raidobw2
Copy link
Author

Hello, I'm doing that real quick before I hit the hay. Ask me more testing for later if you need it. Same versions and using OceanBlock as in my original post.

Before:
image

Pricking with Sacrifial Knife until I die. Gravestone generated:
image

Breaking Gravestone and recovering inventory:
image

@Raidobw2
Copy link
Author

Hello, I'm here to give a small feedback from one of our users. From the FTB modpack issue that's linked:

I died to the Blood Magic dagger without the Draconic Armor and lost my inventory - no grave, so I'd vote it is totally a Blood Magic issue alone.

Hopefully that can confirm your initial thoughts and that it might not be related to DE. Have a nice day!

@smig00
Copy link

smig00 commented Nov 19, 2021

i belive is something to to wit he totem of undying affect it only does it with draconic armor witch allso gives you the affect and lost trinket mod with broken ttotem of undying activating after you die. so the game think you the totem saved you and it does not create a grave or give you the death message
Screenshot_4
Screenshot_2
Screenshot_3

@smig00
Copy link

smig00 commented Nov 19, 2021

i also tried with the normal totem and it dosen't activate

@WayofTime
Copy link
Owner

I have been informed from a fellow modder how to fix this, and I will get it into the next version of the mod.

@Raidobw2
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants