Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request READ_EXTERNAL_STORAGE permission if not already granted #14

Merged
merged 1 commit into from May 19, 2018
Merged

Request READ_EXTERNAL_STORAGE permission if not already granted #14

merged 1 commit into from May 19, 2018

Conversation

Rudloff
Copy link
Member

@Rudloff Rudloff commented May 19, 2018

This patch fixes #9.
The permission is requested when the user opens the wallpaper picker.

@Rudloff Rudloff requested a review from Roboe May 19, 2018 15:37
Roboe
Roboe approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@Roboe Roboe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works well, both denying and allowing, on my LineageOS 14.1 (Fairphone 2) and 15.1 (Nexus 4)

Good work! :)

@Roboe Roboe merged commit dad84f2 into WeAreFairphone:master May 19, 2018
@Rudloff Rudloff deleted the feature/permissions branch May 19, 2018 19:03
@Rudloff Rudloff mentioned this pull request Jun 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roboe Roboe Roboe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when trying to change the wallpaper
2 participants
@Rudloff @Roboe