Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Edit lock provides user active unlock button #1068

Closed
2 tasks done
wxyn opened this issue Jul 7, 2023 · 1 comment
Closed
2 tasks done

[Feature] Edit lock provides user active unlock button #1068

wxyn opened this issue Jul 7, 2023 · 1 comment

Comments

@wxyn
Copy link
Contributor

wxyn commented Jul 7, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Problem Description

Users may need to unlock the function in the following scenarios
If there is a problem during the batch run at night, the operation and maintenance user will find that the workflow has been locked by the development user when checking the corresponding workflow. It can be troublesome to contact development users.
2. When switching between different login devices during work, if you forget to close an open workflow before exiting a VDI, it may cause the corresponding workflow to no longer be able to be closed, so the workflow will remain locked.

Reproducing steps

  1. Scenario 1 is a normal situation
  2. Scenario 2 can be replicated by opening workflows between different login devices

Description

Unlock process:
When the user clicks on the locked workflow, a prompt appears in the upper right corner as shown in the following figure. (The error prompt should be modified here, and the corresponding update should be viewed in the solution document. The solution should provide a description of the user's use of the unlock function.)
If the user needs to unlock, they can use the unlock function on the right menu of the workflow. Regardless of whether the current workflow is locked or not, the user can see the "Unlock" option in the menu.
Unlock orchestration interface:
image
image
image
Unlock User A's Perspective:
Background: When users choose to expand a project (test_get_lock), they will need to edit the workflow under the current project.
If the workflow is unlocked by the front-end and the workflow status is locked:

  1. A Tooltip for unlocking workflow pops up in the middle of the page, as shown in the Tooltip;
  2. If the user clicks "Cancel", the window will disappear and the user has not unlocked the workflow; If you click OK, User A will unlock the workflow and enter the editing page of the workflow to unlock the corresponding workflow for the orchestration;
  3. If the unlocking is successful, it will prompt "Unlock successfully"; If unlocking fails, an error message indicating unlocking failure will be returned in the upper right corner of the page;
  4. After successfully unlocking, the unlocked workflow will not be automatically opened for the user. You still need to click to enter the workflow editing page (separate the steps of unlocking and entering)
    image
    image
    image
    If the front-end unlocks the workflow, the workflow status is unlocked
    The error prompt returned in the upper right corner is shown in the following figure:
    image
    Unlocked User B Perspective:
    In conventional scenarios, User A needs to communicate with User B before unlocking the workflow that User B is editing. After learning about A's requirements, User B can save and close the corresponding workflow.
    If user A fails to communicate with user B according to the DSS prompt, then if user A unlocks and user B is still editing, the next time B completes editing, the front end will call the saveFlow interface to save the workflow. The following error prompt will appear in the upper right corner.
    image

Use case

No response

solutions

No response

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@wxyn wxyn added the enhancement New feature or request label Jul 7, 2023
@zqburde zqburde added this to To do in DataSphereStudio1.1.2 via automation Aug 9, 2023
@zqburde
Copy link
Contributor

zqburde commented Aug 9, 2023

Add it in DSS1.1.2

@zqburde zqburde moved this from To do to Done in DataSphereStudio1.1.2 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants