Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize linkis computation governance module #775

Merged
merged 8 commits into from
Jun 7, 2021
Merged

optimize linkis computation governance module #775

merged 8 commits into from
Jun 7, 2021

Conversation

yangzhiyue
Copy link
Contributor

close #742

optimize linkis computation governance module

Copy link
Contributor

@wushengyeyouya wushengyeyouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Delete all the code of OnceExecutor
  2. JDBC-Driver module and manager module, the top license information of many files are all deleted
  3. All label-common modules are not licensed
  4. Authors of many types of files are not deleted

import java.util

/**
* Created by enjoyyin on 2021/5/21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it.

public class SubJobDetail {

/*
db自增id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify it.

package com.webank.wedatasphere.linkis.ecm.core.conf

/**
* @author leebai
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it.

initializeEnv()
//TODO env需要考虑顺序问题
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it.

@@ -67,9 +67,11 @@ object ECMConfiguration {
/**
* engineconn创建时间,如果为0,则使用ms中默认的
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify it.

Comment on lines 1 to 2
/*
* Copyright 2019 WeBank
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recover it.

@@ -25,6 +9,9 @@ import com.webank.wedatasphere.linkis.ujes.client.UJESClient
import com.webank.wedatasphere.linkis.ujes.jdbc.UJESSQLDriverMain._
import org.apache.commons.lang.StringUtils

/**
* Created by enjoyyin on 2019/5/27.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it.

Comment on lines 1 to 10
/*
* Copyright 2019 WeBank
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recover it please .

Comment on lines 1 to 12
/*
* Copyright 2019 WeBank
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recover it.

@@ -26,6 +10,10 @@ import org.apache.commons.lang.StringUtils

import scala.collection.JavaConversions._


/**
* Created by owenxu on 2019/8/8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it.

1. add license
2. remove author and created by
1. add license
2. remove author and created by
1. add license
2. remove author and created by
1. add license
2. remove author and created by
3. add English comment
Copy link
Contributor

@wushengyeyouya wushengyeyouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wushengyeyouya wushengyeyouya merged commit 6c88ce8 into apache:dev-1.0.0 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants