Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the scala compilation plugin to support JDK8 #961

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Modify the scala compilation plugin to support JDK8 #961

merged 2 commits into from
Aug 16, 2021

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

Modify the scala compilation plugin to support JDK8

Brief change log

(for example:)

  • Modify the scala compilation plugin to support JDK8.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: ( no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Fuu3214
Fuu3214 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@Fuu3214 Fuu3214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fuu3214 Fuu3214 self-requested a review August 16, 2021 12:49
Fuu3214
Fuu3214 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@Fuu3214 Fuu3214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fuu3214 Fuu3214 merged commit b3f0ef8 into apache:dev-1.0.2 Aug 16, 2021
@wushengyeyouya wushengyeyouya mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuu3214 Fuu3214 Fuu3214 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peacewong @Fuu3214