Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize gateway/hiveEngineConn/Entrance modules #967

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Optimize gateway/hiveEngineConn/Entrance modules #967

merged 3 commits into from
Aug 20, 2021

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

  1. remove instance-label client dependency
  2. Solve the host name and ip judgment abnormality in the gateway router
  3. exclude pentaho-aggdesigner-algorithm module

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: ( no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)

Alexkun
Alexkun approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@Alexkun Alexkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@Alexkun Alexkun merged commit 93e6cb9 into apache:dev-1.0.2 Aug 20, 2021
@wushengyeyouya wushengyeyouya mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexkun Alexkun Alexkun approved these changes

Assignees
No one assigned
Labels
component=Computation Governance/linkis-entrance component=EngineConnPlugins/Hive component=SpringCloudServices/Gateway The Gateway component of SpringCloudServices
Projects
No open projects
Linkis1.0.2
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peacewong @Alexkun