Merge pull request #46 from yg3630536/feature/fix-spotbug

Fix the issues generated by spotbug and improve test cases to ensure that they pass
WeBankBlockchain · Feb 25, 2019 · 33da05c · 33da05c
2 parents f23ed30 + ba34550
commit 33da05c
Show file tree

Hide file tree

Showing 46 changed files with 836 additions and 1,609 deletions.
diff --git a/config/spotbugs/spotbugs_filter.xml b/config/spotbugs/spotbugs_filter.xml
@@ -29,5 +29,17 @@
         <Method name="checkAuthorityIssuerArgsValidity" />
         <Bug pattern="REC_CATCH_EXCEPTION" />
     </Match>
+
+    <!-- 
+    	Filtering spotbug problems caused by mock and known empty problems.
+    	1. UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS
+    	2. ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
+    	3. SIC_INNER_SHOULD_BE_STATIC_ANON
+    	4. NP_LOAD_OF_KNOWN_NULL_VALUE
+     -->
+    <Match>
+        <Package name="~com\.webank\.weid\.full\.*.*" />
+        <Bug pattern="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS, ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD, SIC_INNER_SHOULD_BE_STATIC_ANON, NP_LOAD_OF_KNOWN_NULL_VALUE" />
+    </Match>
 
 </FindBugsFilter>
diff --git a/src/demo/com/webank/weid/demo/DemoService.java b/src/demo/com/webank/weid/demo/DemoService.java
diff --git a/src/demo/com/webank/weid/demo/DemoTest.java b/src/demo/com/webank/weid/demo/DemoTest.java