Merge pull request #167 from WeBankFinTech/bugfix/spotbug-style-v161

* Fix spotbug alerts
WeBankBlockchain · Apr 13, 2020 · 6652e11 · 6652e11
2 parents 0e0e0fb + 4f1e18d
commit 6652e11
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/src/main/java/com/webank/weid/service/impl/EvidenceServiceImpl.java b/src/main/java/com/webank/weid/service/impl/EvidenceServiceImpl.java
@@ -211,7 +211,6 @@ private ResponseData<String> hashToNewEvidence(String hashValue, String privateK
                 StandardCharsets.UTF_8);
             Long timestamp = DateUtils.getNoMillisecondTimeStamp();
 
-            //如果
             boolean flag = getOfflineFlag();
             if (flag) {
 
@@ -412,7 +411,7 @@ public ResponseData<String> createEvidenceWithLogAndCustomKey(
                 DataToolUtils.base64Encode(DataToolUtils.simpleSignatureSerialization(sigData)),
                 StandardCharsets.UTF_8);
             Long timestamp = DateUtils.getNoMillisecondTimeStamp();
-            //如果
+
             boolean flag = getOfflineFlag();
             if (flag) {
 

diff --git a/src/main/java/com/webank/weid/service/impl/engine/EvidenceServiceEngine.java b/src/main/java/com/webank/weid/service/impl/engine/EvidenceServiceEngine.java
@@ -34,10 +34,6 @@ ResponseData<String> createEvidence(
         String privateKey
     );
 
-    /**
-     * Batch creation of evidences. Return values are a list which indicates successful or failed
-     * creation with strict order of input evidences.
-     */
     ResponseData<List<Boolean>> batchCreateEvidence(
         List<String> hashValues,
         List<String> signatures,

diff --git a/src/test/java/com/webank/weid/full/evidence/TestCreateEvidence.java b/src/test/java/com/webank/weid/full/evidence/TestCreateEvidence.java
@@ -311,7 +311,7 @@ public void testBatchCreate() throws Exception {
         Assert.assertEquals(booleans.size(), hashValues.size());
         Boolean result = true;
         for (int i = 0; i < booleans.size(); i++) {
-            result &= booleans.get(i);
+            result = result && booleans.get(i).booleanValue();
         }
         Assert.assertTrue(result);
 
@@ -338,7 +338,7 @@ public void testBatchCreate() throws Exception {
         Assert.assertEquals(booleans.size(), hashValues.size());
         result = true;
         for (int i = 0; i < booleans.size(); i++) {
-            result &= booleans.get(i);
+            result = result && booleans.get(i).booleanValue();
         }
         Assert.assertTrue(result);