Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not completely compatible with ActiveRecord >= 6.1 #60

Closed
acroos opened this issue Nov 3, 2021 · 0 comments · Fixed by #61
Closed

Not completely compatible with ActiveRecord >= 6.1 #60

acroos opened this issue Nov 3, 2021 · 0 comments · Fixed by #61
Assignees
@acroos
Labels
bug Something isn't working in-progress This issue is currently being worked on

Comments

@acroos
Copy link
Collaborator

acroos commented Nov 3, 2021

Describe the bug
The add_index and remove_index re-definitions that we do are no longer compatible as some method signatures have changed.

To Reproduce
Create any migration that adds or removes an index (see #59)

Expected behavior
Ghost Adapter should be completely compatible with ActiveRecord >= 6.1

Additional context

  • New add_index_options method here
  • New index_name_for_remove method here
  • New add_index method here
  • New remove_index method here

Also worth noting that the execute method has added an async: argument that we do not support currently here
@acroos acroos added the bug Something isn't working label Nov 3, 2021
@acroos acroos mentioned this issue Nov 3, 2021
Merged
10 tasks
@acroos acroos self-assigned this Nov 3, 2021
@acroos acroos added the in-progress This issue is currently being worked on label Nov 3, 2021
@acroos acroos closed this as completed in #61 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acroos acroos

Labels
bug Something isn't working in-progress This issue is currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ActiveRecord >= 6.1 compatibility WeTransfer/ghost_adapter
1 participant
@acroos