Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Configuration #395

Open
CJCrafter opened this issue Feb 16, 2024 · 1 comment · May be fixed by #410
Open

Faster Configuration #395

CJCrafter opened this issue Feb 16, 2024 · 1 comment · May be fixed by #410
Labels
enhancement New feature or request good first issue Easy contribution if you are a DEV looking to join the team

Comments

@CJCrafter
Copy link
Member

Create a new config system that separates by data type, and uses a "fast lib" for primitives (Or we implement our own, similar to DoubleMap).

Online comparisons suggest that getting types may take $\frac 1 6^{th}$ the time, which is not even considering that hash collisions could be reduced by having multiple maps. This would also take less memory, since we wouldn't have to use java's wrapper classes for primitives, which take >3x the data. Unfortunately, this isn't the biggest improvement since we already use serializers to "condense" objects. For example, block damage config gets condensed into BlockDamage, which doesn't use primitive wrappers.

@CJCrafter CJCrafter added enhancement New feature or request good first issue Easy contribution if you are a DEV looking to join the team labels Feb 16, 2024
@CJCrafter
Copy link
Member Author

@CJCrafter CJCrafter linked a pull request Apr 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Easy contribution if you are a DEV looking to join the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant