Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config json / yml tree - build.json doesn't have all bundles ? #39

Closed
Januszpl opened this issue Oct 30, 2018 · 2 comments
Closed

Config json / yml tree - build.json doesn't have all bundles ? #39

Januszpl opened this issue Oct 30, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@Januszpl
Copy link
Contributor

Januszpl commented Oct 30, 2018

Not sure if I create config tree properly but when experimenting I saw it stop generated other bundles in build.json. I've also tested sample config and added children to bundles/product

{
  "name": "bundles/basket2",
  "urls": [
    "/index.php/checkout/cart2/",
    "/index.php/checkout/cart2"
  ],
  "children": [
    {
      "name": "bundles/checkout2",
      "urls": [
        "/index.php/checkout2/"
      ],
      "children": [

      ]
    }
  ]
}

so now sample config looks like:

{
  "bundles": [
    {
      "name": "bundles/main",
      "urls": [
        "/",
        "/index.php/women/tops-women/jackets-women.html"
      ],
      "children": [
        {
          "name": "bundles/product",
          "urls": [
            "/index.php/juno-jacket.html"
          ],
          "children": [
          {
              "name": "bundles/basket2",
              "urls": [
                "/index.php/checkout/cart2/",
                "/index.php/checkout/cart2"
              ],
              "children": [
                {
                  "name": "bundles/checkout2",
                  "urls": [
                    "/index.php/checkout2/"
                  ],
                  "children": [

                  ]
                }
              ]
            }
          ]
        },
        {
          "name": "bundles/basket",
          "urls": [
            "/index.php/checkout/cart/",
            "/index.php/checkout/cart"
          ],
          "children": [
            {
              "name": "bundles/checkout",
              "urls": [
                "/index.php/checkout/"
              ],
              "children": [

              ]
            }
          ]
        }
      ]
    }
  ]
}

and the build.json:

{
  "generateSourceMaps": true,
  "inline_text": true,
  "optimize": "none",
  "deps": [],
  "map": {},
  "config": {},
  "shim": {},
  "paths": {},
  "modules": [
    {
      "name": "requirejs/require",
      "include": [],
      "exclude": [],
      "create": false
    },
    {
      "name": "bundles/main",
      "include": [],
      "exclude": [
        "requirejs/require"
      ],
      "create": true
    },
    {
      "name": "bundles/product",
      "include": [],
      "exclude": [
        "requirejs/require",
        "bundles/main"
      ],
      "create": true
    },
    {
      "name": "bundles/basket2",
      "include": [],
      "exclude": [
        "requirejs/require",
        "bundles/main",
        "bundles/product"
      ],
      "create": true
    },
    {
      "name": "bundles/checkout2",
      "include": [],
      "exclude": [
        "requirejs/require",
        "bundles/main",
        "bundles/product",
        "bundles/basket2"
      ],
      "create": true
    }
  ]
}

it missing bundles/basket and bundles/checkout

@Januszpl Januszpl changed the title Config json / yml tree Config json / yml tree - build.json doesn't have all bundles ? Oct 31, 2018
@shakyShane
Copy link
Contributor

@Januszpl that config looks correct, I'll look into this.

@shakyShane
Copy link
Contributor

yep, that's certainly a bug, thanks for pointing it out - we'll get it resolved ASAP

@shakyShane shakyShane added the bug Something isn't working label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants