-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor script.js to pass firefox review #29
Comments
Merged #31 into #25 all thanks to @JBenedicto13 for taking the time to fix and refactoring the code base and improving the project. Salute! 🫡 |
@JBenedicto13 unfortunately, we didn't pass the review again. Kindly see the details from Firefox team. Details:
Please address the issues raised in the reviewer's notes and inquire about any unclear items. Afterwards, please upload a new version of your add-on at https://addons.mozilla.org/en-US/developers/addon/matuto/versions. Thank you for your attention. |
I have come to a solution of using DOMPurify to purify the string on line 8 please take a look at my pull request. Thanks. |
Alright checking and testing @JBenedicto13 |
Closing, as the fix is available in the #34 |
Details
The version 0.1.3 didn't pass the review from Firefox add-ons due to the following reasons below.
Task
We need help updating or refactoring the
script.js
to align with their requested changes.The text was updated successfully, but these errors were encountered: