Add appveyor.yml for Windows CI #623

ghost · 2016-07-08T11:57:58Z

Added jobs for MinGW (64 bit) and MSVC (32 and 64 bits) with Release
configurations as well as MSVC (64 bit) with Debug configuration.
Added badge to README.

Commit 005929e build status: https://ci.appveyor.com/project/jasonwilliams200OK/binaryen/build/1.0.37

@kripken, to set it up, please login to AppVeyor with your GitHub account and chose WebAssembly org from the drop down (post login). Then add binaryen project from top menu and press build.

I have also added ctest command (doing nothing atm) which would function if we configure the tests in CMakeLists with ctest runner (aka cross-platform tests,: https://cmake.org/cmake/help/v3.0/manual/ctest.1.html). Examples can be found here: https://github.com/search?l=cmake&q=cmake+ENABLE_TESTING&type=Code&utf8=✓

ghost · 2016-07-08T15:46:12Z

CMakeLists.txt

@@ -67,7 +67,11 @@ ELSE()
  ADD_COMPILE_FLAG("-Wextra")
  ADD_COMPILE_FLAG("-Wno-unused-parameter")
  ADD_COMPILE_FLAG("-fno-omit-frame-pointer")
-  ADD_COMPILE_FLAG("-fPIC")
+  IF(WIN32)
+    ADD_COMPILE_FLAG("-D_GNU_SOURCE")


Without it, MinGW job fails at 76% like https://ci.appveyor.com/project/jasonwilliams200OK/binaryen/build/1.0.36/job/36pvx89h7g52g09n#L110.

kripken · 2016-07-08T16:16:24Z

Ok, I logged into appveyor, but I'm not sure where to find the dropdown you mention?

ghost · 2016-07-08T17:01:32Z

When you log on with GitHub Account, it would show a dropdown menu to select organization before proceeding to dashboard (given you are a member of WebAssembly org on GitHub).

ghost · 2016-07-08T17:02:14Z

It's all green now https://ci.appveyor.com/project/jasonwilliams200OK/binaryen/build/1.0.37 😄

kripken · 2016-07-08T17:37:48Z

Hmm, I logged in with my github account, but I just get sent to what I guess is the dashboard (a big mostly empty page with "Welcome to your new AppVeyor account!"

If I try to create a new project it asks for more oath permissions (admin access to webhooks etc.) and has a bunch of options there. Is that the right thing?

ghost · 2016-07-08T17:52:02Z

This is how it appears to me:

Before login:

After login with GitHub account:

When I select the organization name from the drop down menu and press GitHub button again on the second screen, it takes me to https://ci.appveyor.com/projects where it lists the projects of this organization which are being monitored by AppVeyor. If it is some existing project which hasn't been configured yet, then we press the New Project button on top and list GitHub, BitBucket and so on in the left menu and the available projects in the right.

Did you grant it access to your public repositories and organizations? Had you opted for no, then you can change it again by going to https://ci.appveyor.com/account, where you can revoke the github access and reauthorize .. this time permissively. 😄

kripken · 2016-07-08T17:57:43Z

Ok, it might be those extra auths. I granted them now.

However while granting them it said that for the webassembly org in particular I can just ask for access. So I asked for it, it said it emailed the owners.

kripken · 2016-07-08T18:02:31Z

Ok, all that should be ok now. But after I logging in I still get sent straight to the dashboard. Should I just create a new project? When I do that I get https://ci.appveyor.com/project/kripken/binaryen which looks empty

ghost · 2016-07-08T18:19:03Z

I think your issue seems to be related to appveyor/ci#801 (comment) and appveyor/ci#802. What I have gathered from this situation (which the issues probably don't list yet) is that if you are a collaborator to an organization and your membership is not visible publicly (GitHub profile such as in your profile WebAssembly is not listed to public), then AppVeyor doesn't recognize the membership. If you make the membership to WebAssembly visible and Revoke->then->Authorize again, does it then land you to the second-step login screen?

you can make your membership back to invisible after configuring the repo :)

kripken · 2016-07-08T18:24:53Z

Yeah, I thought it might be that earlier so I edited myself to public. That was almost an hour ago but I still don't see the WebAssembly group among my public groups on my profile though...

@dschuff, maybe you can try to do this? (you have equal collaborator status as I do on this repo) It should just be logging in as per the first comment in this PR, so just a few seconds to see if you don't hit whatever weirdness is blocking me.

dschuff · 2016-07-08T18:28:24Z

I wonder if it's not the status on the repo but on the WebAssembly organization that makes a difference. Neither of us is actually an owner of that organization.

dschuff · 2016-07-08T18:31:40Z

I was able to make a build ( https://ci.appveyor.com/project/dschuff/binaryen ) that seems to be from the WebAssembly binaryen repo. I don't know if it matters that it's project/dschuff rather than project/WebAssembly or some such?

ghost · 2016-07-08T19:34:44Z

Great, then it probably doesn't matter if it is observing the upstream rather than the fork (which is another kind of weirdness since that is suppose to only happen at https://ci.appveyor.com/project/WebAssembly/binaryen).

You can also view the settings page of this repo to find AppVeyor generic webhook: https://github.com/WebAssembly/binaryen/settings/hooks (just to validate everything is fine). It should be something like https://ci.appveyor.com/api/github/webhook (pull_request and push). If that is there, then I will update README in this PR to point to dschuff/binaryen since that is configured. Whenever the upstream account will be setup, only the badge URL in README would be good to change.

Please let me know if the webhook is there so i can amend the commit. :)

ghost · 2016-07-08T19:42:38Z

@kripken, regarding the publicly visible membership, there seems to be a profile setting on GitHub, which lists the organizations under the display picture on profile page (https://github.com/kripken) for public. For example I can only see Unity3D logo on your profile. Probably AppVeyor is relying on the same kind of scope.

dschuff · 2016-07-08T19:45:58Z

I don't appear to have access to the settings of WebAssembly/binaryen. I might be some kind of contributor or commiter rather than an owner.

ghost · 2016-07-08T19:56:36Z

@dschuff, I googled the issue again and found this: http://help.appveyor.com/discussions/questions/1154-appveyor-account-for-github-organizations. This probably translates to our scenario like this:

As a collaborator (of any kind), signup with a regular appveyor account for organization called WebAssembly: https://ci.appveyor.com/signup.
Login with that account and go to https://ci.appveyor.com/account page and authorize with GitHub.
Then go to https://ci.appveyor.com/projects/new, select GitHub (first item in left menu -- already selected), scroll down to organization called WebAssembly and take binaryen from there.

If that works then we will have https://ci.appveyor.com/project/WebAssembly/binaryen and this PR is good to go as is. :)

Would you give it a try? Otherwise i will update the URL in readme.

dschuff · 2016-07-08T20:19:30Z

https://ci.appveyor.com/project/WebAssembly/binaryen

Seems to work.
The only problem now is that I accidentally signed up for a trial of the private-project account instead of the free OSS account, and I don't see a way to convert it from the account config (I can only buy the ugprades). I'll look into that.

dschuff · 2016-07-08T20:20:57Z

Actually it looks like that's not a problem according to http://help.appveyor.com/discussions/questions/1118-how-to-change-my-plan-to-free-for-open-source-projects so we should be good.

ghost · 2016-07-08T20:24:38Z

Great! Thanks @dschuff. Then this PR as is ready. :)

I have re-pushed the commit to see if AppVeyor shows up on the PR, but it does not. Seems like this solution might work: http://stackoverflow.com/questions/32607885/appveyor-doesnt-update-github-pull-request-with-the-build-status.

dschuff · 2016-07-08T20:35:57Z

OK, I tried revoking and re-authorizing.

dschuff · 2016-07-08T20:38:02Z

Also tried a test PR: #624 but it doesn't appear to have triggered a build.

ghost · 2016-07-08T21:45:11Z

@FeodorFitsner (from AppVeyor) could you please suggest what steps need to be taken in this case to make AppVeyor build trigger in PR? Here is the account setup https://ci.appveyor.com/project/WebAssembly/binaryen and this PR is adding appveyor.yml but it is not triggering the build.

FeodorFitsner · 2016-07-09T05:17:25Z

Make sure AppVeyor's webhook is added to the repo. You can see webhook URL on General tab of AppVeyor project settings.

ghost · 2016-07-09T09:17:49Z

Thanks Feodor. I think we need someone with access to https://github.com/WebAssembly/binaryen/settings/hooks to verify if the appveyor webhook "Payload URL" value is same as the value of "Webhook URL" at https://ci.appveyor.com/project/WebAssembly/binaryen/settings. This normally gets added automatically and we never have to visit the settings page, but in this case we might have different URL.
@dschuff, can you ping the owner of repo? Note that the full payload URL gets visible in edit mode; on list view it just shows https://ci.appveyor.com/api/github/webhook (pull_request and push) (not the ?id part) clicking on it will open the edit view.

dschuff · 2016-07-11T16:13:47Z

IIRC @kripken is the owner of the repo. (If not, then @jfbastien should be able to check).

kripken · 2016-07-11T16:28:26Z

No, I'm just a collaborator like you, @dschuff. The owners are I guess the WebAssembly group owners that created the repo for us.

jfbastien · 2016-07-11T16:53:17Z

I think I just installed the hook properly. LMK if that's not the case.

jfbastien · 2016-07-11T16:53:59Z

Also, @kripken and @dschuff should already be admins for the binaryen repo.

dschuff · 2016-07-11T16:54:16Z

Cool. Things seem to be happening now on my test PR: #624

ghost · 2016-07-11T17:02:12Z

Thanks. I pushed a test commit, apparently it didn't triggered. :(

dschuff · 2016-07-11T17:04:00Z

The hook only included 'push' but not 'pull request'. since my PR was on a branch in the WebAssembly repo itself, and yours was on a forked repo, maybe that explains the different. I added the 'pull_request' event too. try again?

dschuff · 2016-07-11T17:05:43Z

Actually, hold off 1 sec.

dschuff · 2016-07-11T17:05:51Z

oh it did work that time. cool.

ghost · 2016-07-11T17:10:46Z

Yay, it worked! Thanks Derek. :)

The whole job matrix takes about an hour to build. We may want to remove the Debug builds or fast_finish+allow_failure (https://www.appveyor.com/docs/appveyor-yml line 105). What do you think?

dschuff · 2016-07-11T17:26:02Z

So right now we have Debug/Release x (Msys x 32/64 + VS2015 x 32/64)?
Do we expect a lot of people to be doing Windows 32 builds? My guess is that almost all devs doing Linux and Windows-hosted builds will be using 64. I would guess that emscripten/wasm itself will be the most common 32-bit target :).

ghost · 2016-07-11T17:26:55Z

Oh wow, it is taking 12 mins! I guess its a paid account thing (since the account is in trial period). So it spawns one VM per job on Azure cloud. For regular account it probably builds on their local servers using some first-come-first-serve / merry-go-round protocol. 😄

dschuff · 2016-07-11T17:29:44Z

Maybe for now let's drop the debug builds for Msys and 32-bit VS. (I would expect users wanting to debug would prefer VS and be using 64-bit). We can always tweak later.

ghost · 2016-07-11T17:30:06Z

We have: { mingw64, msvcr32 and msvcr64 } x { Debug, Release } configurations.

* Added jobs for MinGW (64 bit) and MSVC (32 and 64 bits) with Release configurations as well as MSVC (64 bit) with Debug configuration. * Added badge to README.

ghost · 2016-07-11T17:35:57Z

Amended; now we have mingw64 and msvcr{32,64} in Release, as well as msvc64 in Debug. Total of four jobs.

dschuff · 2016-07-11T19:42:06Z

Great! I think this can go now, we can tweak as needed.

ghost · 2016-07-11T20:05:20Z

@FeodorFitsner, the badge URL https://ci.appveyor.com/api/projects/status/github/WebAssembly/binaryen?svg=true (public repo format) is rendering failure , while the build on master head is passing. Given that this account is trail and considered paid until the account expired while the repo is public, would we have to wait until the trail expired to get green status from badge using public URL format?

FeodorFitsner · 2016-07-11T20:08:04Z

I guess there is another project using the same GitHub repo. To use this format the repo should be unique in AppVeyor database.

dschuff · 2016-07-11T20:47:34Z

I'll switch it to use the unique one from the appveyor project: #626

ghost reviewed Jul 8, 2016
View reviewed changes

Add appveyor.yml for Windows CI

faa3a82

* Added jobs for MinGW (64 bit) and MSVC (32 and 64 bits) with Release configurations as well as MSVC (64 bit) with Debug configuration. * Added badge to README.

dschuff merged commit 7f4c129 into WebAssembly:master Jul 11, 2016

ghost deleted the feature/ci/appveyor branch July 11, 2016 19:46

ghost mentioned this pull request Jul 27, 2016

Respond to Castle's NetCore port. alexandrnikitin/NSubstitute#7

Merged

dschuff mentioned this pull request Oct 25, 2016

We should have an AppVeyor build WebAssembly/wabt#186

Closed

Add appveyor.yml for Windows CI #623

Add appveyor.yml for Windows CI #623

Conversation

ghost commented Jul 8, 2016 • edited by ghost

ghost Jul 8, 2016

Choose a reason for hiding this comment

kripken commented Jul 8, 2016

ghost commented Jul 8, 2016 • edited by ghost

ghost commented Jul 8, 2016

kripken commented Jul 8, 2016

ghost commented Jul 8, 2016

kripken commented Jul 8, 2016

kripken commented Jul 8, 2016

ghost commented Jul 8, 2016

kripken commented Jul 8, 2016

dschuff commented Jul 8, 2016

dschuff commented Jul 8, 2016

ghost commented Jul 8, 2016

ghost commented Jul 8, 2016

dschuff commented Jul 8, 2016

ghost commented Jul 8, 2016

dschuff commented Jul 8, 2016

dschuff commented Jul 8, 2016

ghost commented Jul 8, 2016

dschuff commented Jul 8, 2016

dschuff commented Jul 8, 2016

ghost commented Jul 8, 2016

FeodorFitsner commented Jul 9, 2016

ghost commented Jul 9, 2016

dschuff commented Jul 11, 2016

kripken commented Jul 11, 2016

jfbastien commented Jul 11, 2016

jfbastien commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 11, 2016

dschuff commented Jul 11, 2016

dschuff commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 11, 2016

ghost commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 11, 2016

FeodorFitsner commented Jul 11, 2016

dschuff commented Jul 11, 2016

ghost commented Jul 8, 2016 •

edited by ghost

ghost commented Jul 8, 2016 •

edited by ghost