Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about tail-invocation stack value length assertion (item 3) #10

Closed
jacobmischka opened this issue Apr 25, 2020 · 3 comments
Closed

Comments

@jacobmischka
Copy link

I'm reading through the spec, and https://github.com/WebAssembly/tail-call/blame/master/document/core/exec/instructions.rst#L1134 says that there must be at least m values on the stack, but then proceeds to pop n items from it

Should that m be n? Or am I misunderstanding something?

@rossberg
Copy link
Member

That's a typo, the assertion should have said n. Fixed now.

@jacobmischka
Copy link
Author

jacobmischka commented Apr 27, 2020

Thanks! Should the frame subscript here still be m? Or should that be n as well?

https://github.com/WebAssembly/tail-call/blame/master/document/core/exec/instructions.rst#L1155

@rossberg
Copy link
Member

No, that must match the return arity of the function called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants