Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for bufferSize in createScriptProcessor() #140

Closed
olivierthereaux opened this issue Sep 11, 2013 · 4 comments
Closed

Default value for bufferSize in createScriptProcessor() #140

olivierthereaux opened this issue Sep 11, 2013 · 4 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-17392 Tue, 05 Jun 2012 12:12:16 GMT
Reported by Michael[tm] Smith
Assigned to

Audio-ISSUE-14 (quinnirill): Default value for bufferSize in createJavaScriptNode() [Web Audio API]

http://www.w3.org/2011/audio/track/issues/14

Raised by: Jussi Kalliokoski
On product: Web Audio API

Jussi Kalliokoski suggested that the first argument of AudioContext:createJavasScriptNode, (buffer size) would be made optional.

In addition, it could be specified so that an advanced implementation would adjust the default value to be an optimal balance between reliability (avoiding glitches and underruns) and latency on that system and setup.

@olivierthereaux
Copy link
Contributor Author

Original comment by Olivier Thereaux on W3C Bugzilla. Thu, 07 Jun 2012 15:49:16 GMT

Comment from Jussi in http://lists.w3.org/Archives/Public/public-audio/2012AprJun/0106.html

«
We discussed with Chris (off-list) the recent change from numberOfOutputs
to numberOfChannels in the createJavaScriptNode(), because I noticed my
sink.js was broken in the latest Chrome Canary.

I suggested that the first parameter (bufferSize) be optional as well,
reverting to default when passed undefined. In an advanced implementation,
this default could be adjusted to a value that the implementation deems a
good tradeoff between safety (avoiding underruns) and latency on that
system and setup. I believe Chris thinks this is a good idea, so he
suggested I bring this to discussion in the group so we can change the spec
if we agree on it.
»

@olivierthereaux
Copy link
Contributor Author

Original comment by Olivier Thereaux on W3C Bugzilla. Fri, 26 Jul 2013 15:01:48 GMT

The method is currently defined as:

ScriptProcessorNode createScriptProcessor(optional unsigned long bufferSize = 0 …

Is this issue still valid or is has it been fixed already?

@olivierthereaux
Copy link
Contributor Author

Original comment by Olivier Thereaux on W3C Bugzilla. Fri, 26 Jul 2013 15:02:27 GMT

Updating issue title to reflect the change of name from JavaScriptAudioNode to
ScriptProcessorNode, and in particular the createScriptProcessor method.

@olivierthereaux
Copy link
Contributor Author

Original comment by Ehsan Akhgari [:ehsan] on W3C Bugzilla. Fri, 26 Jul 2013 19:10:11 GMT

I think it's safe to call this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant