Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final gain not defined in DynamicsCompressor algorithm #1504

Closed
rtoy opened this issue Feb 23, 2018 · 2 comments
Closed

final gain not defined in DynamicsCompressor algorithm #1504

rtoy opened this issue Feb 23, 2018 · 2 comments
Assignees

Comments

@rtoy
Copy link
Member

rtoy commented Feb 23, 2018

In https://webaudio.github.io/web-audio-api/#processing look for the algorithm for computing the reduction gain (below the audio graph diagram). In step 6.10, we have

Compute metering gain to be final gain, converted to decibel.

I take this to mean metering gain is set to final gain. But a search for "final gain" shows that this is the only place in the spec where this is used. This needs some clarification.

@rtoy
Copy link
Member Author

rtoy commented Feb 23, 2018

LIkewise, the threshold and knee are mentioned in the algorithm, but not used anywhere within.

@rtoy
Copy link
Member Author

rtoy commented Mar 2, 2018

Closing this. Let #1502 be the issue about DynamicsCompressor algorithm missing explanations of these parameters.

@rtoy rtoy closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants