Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"active source" flag handling is a weird monkeypatch #1970

Closed
bzbarsky opened this issue Jul 5, 2019 · 0 comments · Fixed by #2034
Closed

"active source" flag handling is a weird monkeypatch #1970

bzbarsky opened this issue Jul 5, 2019 · 0 comments · Fixed by #2034
Assignees
Projects

Comments

@bzbarsky
Copy link

bzbarsky commented Jul 5, 2019

https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process says:

At the conclusion of each call to the process() method, ToBoolean (described in [ECMASCRIPT]) is applied to the return value and the result is assigned to the associated AudioWorkletProcessor’s active source flag.

This is a pretty weird place to put that handling, imo, assuming this is meant to be a normative requirement (which I assume it is, since nothing else really sets the flag). It would be a lot clearer if it happened at https://webaudio.github.io/web-audio-api/#rendering-a-graph step 3.4.4.2.3 or so, where we actually make the call. Otherwise it's pretty easy to miss this requirement while implementing the processing model steps.

Having an informative note about what the function's return value means does make some sense.

@hoch hoch added this to Untriaged in V1 Jul 11, 2019
@padenot padenot self-assigned this Jul 11, 2019
@hoch hoch moved this from Untriaged to In WG Discussion in V1 Jul 18, 2019
@hoch hoch moved this from In WG Discussion to Ready for Editing in V1 Aug 20, 2019
V1 automation moved this from Ready for Editing to Done Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V1
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants