Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AudioContext]: 'activeSourceCount' should return number of all active Source nodes #206

Closed
olivierthereaux opened this issue Sep 11, 2013 · 4 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-21862 Mon, 29 Apr 2013 02:11:32 GMT
Reported by Praveen R Jadhav
Assigned to

'activeSourceCount' should return no. of active AudioBufferSourceNodes, OscillatorNodes and ScriptProcessoreNodes(this can generate audio too) at any given time. Current WebKit code returns no. of active AudioBufferSourceNodes and OscillatorNodes.

@olivierthereaux
Copy link
Contributor Author

Original comment by Ehsan Akhgari [:ehsan] on W3C Bugzilla. Tue, 07 May 2013 00:30:57 GMT

We are planning to remove the activeSourceCount property from AudioContext. Its functionality can be implemented in Javascript by handling the "ended" event on AudioBufferSourceNodes.

@olivierthereaux
Copy link
Contributor Author

Original comment by Praveen R Jadhav on W3C Bugzilla. Tue, 07 May 2013 13:17:37 GMT

Thanks Ehsan. I can see that "ended" event is added in AudioBufferSourceNode and OscillatorNode IDL. But MediaElementAudioSourceNode and MediaStreamAudioSourceNode too are source nodes and should also include this event.
Better way should be sending "ended" event from AudioSourceNode IDL(Dummy implementation already available in WebKit) and inherit this in other source nodes, IMO.

@olivierthereaux
Copy link
Contributor Author

Original comment by Ehsan Akhgari [:ehsan] on W3C Bugzilla. Tue, 07 May 2013 13:25:24 GMT

(In reply to comment #2)

Thanks Ehsan. I can see that "ended" event is added in AudioBufferSourceNode
and OscillatorNode IDL. But MediaElementAudioSourceNode and
MediaStreamAudioSourceNode too are source nodes and should also include this
event.

HTMLMediaElement and MediaStream both have their own ended events which can be used for this purpose.

Better way should be sending "ended" event from AudioSourceNode IDL(Dummy
implementation already available in WebKit) and inherit this in other source
nodes, IMO.

FWIW AudioSourceNode has also been removed from the spec, and it should be removed from WebKit as well.

@olivierthereaux
Copy link
Contributor Author

Original comment by Olivier Thereaux on W3C Bugzilla. Fri, 05 Jul 2013 09:38:12 GMT

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant