Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifetime of pending processor construction data and exceptions in instantiation of AudioWorkletProcessor when AudioWorkletProcessor() constructor is not invoked #2119

Closed
karlt opened this issue Jan 10, 2020 · 1 comment · Fixed by #2306
Assignees
Projects

Comments

@karlt
Copy link
Contributor

karlt commented Jan 10, 2020

The instantiation of AudioWorkletProcessor algorithm sets the node reference and transferred port of the AudioWorkletGlobalScope's pending processor construction data.

Only the AudioWorkletProcessor() constructor arranges for this data to be cleared, but "Construct a callback function" in the instantiation of AudioWorkletProcessor does not necessarily invoke the AudioWorkletProcessor() constructor.

I assume that steps to "Empty the pending processor construction data slot" and "queue a task to the control thread to fire an event named processorerror" should be moved from the AudioWorkletProcessor() constructor to the instantiation of AudioWorkletProcessor algorithm?

Some more details are in #2096, but perhaps all the details there occluded the core of the issue.

@hoch hoch self-assigned this Jan 23, 2020
@rtoy rtoy added this to Untriaged in V1 via automation Jan 23, 2020
@rtoy rtoy moved this from Untriaged to In WG Discussion in V1 Jan 23, 2020
@guest271314

This comment was marked as off-topic.

@mdjp mdjp moved this from In WG Discussion to Ready for Editing in V1 Mar 19, 2020
V1 automation moved this from Ready for Editing to Done Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V1
  
Done
4 participants