Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NamingInconsistency): Interface naming inconsistency #219

Closed
olivierthereaux opened this issue Sep 11, 2013 · 4 comments
Closed

(NamingInconsistency): Interface naming inconsistency #219

olivierthereaux opened this issue Sep 11, 2013 · 4 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-17407 Tue, 05 Jun 2012 12:37:14 GMT
Reported by Michael[tm] Smith
Assigned to

Audio-ISSUE-25 (NamingInconsistency): Interface naming inconsistency [Web Audio API]

http://www.w3.org/2011/audio/track/issues/25

Raised by: Marcus Geelnard
On product: Web Audio API

The naming of interfaces, such as different types of audio nodes, is quite inconsistent.

For instance:

  • With or without Audio prefix? (e.g. AudioGainNode vs DelayNode)
  • With or without Node suffix? (e.g. AudioPannerNode vs AudioChannelSplitter)
@olivierthereaux
Copy link
Contributor Author

Original comment by Chris Rogers on W3C Bugzilla. Fri, 05 Oct 2012 18:56:54 GMT

Here is a suggested re-naming which is more consistent. Using this naming, "Audio" is still present in AudioBufferSourceNode because "AudioBuffer" is the name of the object used by this node. "Audio" is still present in MediaElementAudioSourceNode and MediaStreamAudioSourceNode because it's important to distinguish audio from video.

AudioBufferSourceNode
MediaElementAudioSourceNode
MediaStreamAudioSourceNode
JavaScriptAudioNode ------------> ScriptProcessorNode
RealtimeAnalyserNode ------------> AnalyserNode
AudioGainNode ------------> GainNode
DelayNode
BiquadFilterNode
AudioPannerNode ------------> PannerNode
ConvolverNode
AudioChannelSplitter ------------> ChannelSplitterNode
AudioChannelMerger ------------> ChannelMergerNode
DynamicsCompressorNode
Oscillator ------------> OscillatorNode

@olivierthereaux
Copy link
Contributor Author

Original comment by Marcus Geelnard (Opera) on W3C Bugzilla. Thu, 11 Oct 2012 14:08:44 GMT

(In reply to comment #1)

Sounds good to me.

@olivierthereaux
Copy link
Contributor Author

Original comment by Chris Rogers on W3C Bugzilla. Tue, 16 Oct 2012 00:24:23 GMT

Thanks Marcus, fixed:
https://dvcs.w3.org/hg/audio/rev/1b846a5bcf3e

@olivierthereaux
Copy link
Contributor Author

Original comment by Olivier Thereaux on W3C Bugzilla. Wed, 24 Oct 2012 09:07:25 GMT

OP and editor happy with changes.
No objection.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant