Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec what happens if a AudioBufferSourceNode is connected to two distinct PannerNodes #59

Closed
olivierthereaux opened this issue Sep 11, 2013 · 7 comments

Comments

@olivierthereaux
Copy link
Contributor

Originally reported on W3C Bugzilla ISSUE-21596 Fri, 05 Apr 2013 15:46:48 GMT
Reported by paul@paul.cx
Assigned to

Say we have the following setup:

Source1 ----> Panner1 ----> Destination
| |
`---> Panner2 --------'

Where:

  • Source1 is an AudioBufferSourceNode ;
  • Panner1 and Panner2 are two PannerNodes, with listener and source velocity set such as the doppler shift is different from 1.0 ;
  • Destination is the context's destination node.

The spec seems to assume that an AudioBufferSourceNode can be connected to only one PannerNode.

@joeberkovitz
Copy link
Contributor

@padenot I'm sorry, I can't find the assumption that you're referring to. Is there still a problem here?

@padenot
Copy link
Member

padenot commented Oct 23, 2014

A PannerNode can adjust the playbackRate of AudioBufferSourceNodes that are connected directly or indirectly (quoting the spec), to simulate a doppler effect. What is not specced is what happens when you have multiple PannerNode, having two different velocity values, downstream of a single AudioBufferSourceNode.

But we are talking about changing this AudioNode in a way that would make fixing this useless, so let's wait until we know what will happen to the PannerNode

@joeberkovitz
Copy link
Contributor

OMG. I never read this section carefully. IMHO we must get rid of this doppler thing if that is how it's supposed to work (and I know Chris would like to).

@joeberkovitz
Copy link
Contributor

#372 may render this moot.

@padenot
Copy link
Member

padenot commented Oct 23, 2014

I agree it's certainly not the most useful feature of the API.

@cwilso
Copy link
Contributor

cwilso commented Oct 23, 2014

It's the hackiest part of the entire API as well. At a minimum with PannerNode, we should remove Doppler effects: remove dopplerFactor and speedOfSound from AudioListener, and remove setVelocity from PannerNode and AudioListener.

@cwilso
Copy link
Contributor

cwilso commented Oct 30, 2014

Closing this, as it's obviated by #372 .

@cwilso cwilso closed this as completed Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants