Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg eating up all of our character limit. #59

Open
tw2113 opened this issue Dec 22, 2018 · 0 comments
Open

Gutenberg eating up all of our character limit. #59

tw2113 opened this issue Dec 22, 2018 · 0 comments

Comments

@tw2113
Copy link
Member

tw2113 commented Dec 22, 2018

We default to 800 which had been fine and good...pre Gutes.

Due to how blocks were made and the delimiters for each block, we're going to hit the limit pretty quick.

Do we want to simply increase that limit a lot for WP 5.0.0+ ? We have a filter available already that we could conditionally use.

Do we want to investigate the regex that core may use to parse out each block, and re-use that ourselves to strip the delimiters out before we do our own string searching?

Do we want to just do preg_match_all on the entirety of the content string and do away with the limit completely? We'd be able to pluck out the first found result anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant