Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metabox markup/styling on term pages doesn't match default metaboxes #552

Open
MickeyKay opened this issue Dec 21, 2015 · 3 comments
Open
Labels

Comments

@MickeyKay
Copy link

image

When testing the cmb2-rest-api branch, and outputting on term pages, CMB2's metabox markup doesn't match the default WP metabox markup, and as such some of the default styling doesn't apply.

The default opening markup is:
<table class="form-table">

. . . to which the following CSS is applied:

table.form-table {
    border: 1px solid #ccc;
    padding: 4px 8px;
    border-collapse: separate;
    margin: 16px 0;
}

However CMB2 outputs the following markup:
<div class="table-form">

As such, the default styling isn't applied.

MickeyKay added a commit to MickeyKay/CMB2 that referenced this issue Dec 21, 2015
Addresses CMB2#552. Wraps the existing taxonomy term metabox output in a
table and associated tbody, tr, and td elements to match default
WordPress markup.
MickeyKay added a commit to MickeyKay/CMB2 that referenced this issue Dec 21, 2015
Addresses CMB2#552. Wraps the existing taxonomy term metabox output in a
table and associated tbody, tr, and td elements to match default
WordPress markup.
@jtsternberg
Copy link
Member

What, specifically, is the issue that you are seeing?

@MickeyKay
Copy link
Author

When working with the cmb2-rest-api branch, metaboxes that are output on taxonomy term pages in the admin don't match the default metabox styling on those pages, because the markup doesn't match the default metabox markup:

CMB2 Metabox
(No border, padding, title is different size, etc)
image

Default metabox
image

@jtsternberg
Copy link
Member

The form markup for CMB2 a) intentionally avoids tables for markup, and b) intentionally matches the default WordPress fields for continuity:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants