This repository has been archived by the owner on Apr 10, 2021. It is now read-only.
Bounce At Boundaries on Swipe #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When swiping near an AwesomeMap's boundaries, allow the content to bounce into place to visually convey the boundary condition to the user. Make this effect available via the BoundaryInterceptor's 'slow' mode. Update PeekInterceptor to independently manage drags into boundaries so that the BoundaryInterceptor can use 'slow' mode. This has the beneficial side-effect of allowing users to drag the first and last items in the list away from list boundaries and have the content snap back upon release, thus visually conveying the boundary condition in that case as well.
| @@ -267,7 +285,44 @@ define(function(require) { | |||
|
|
|||
| // Apply acceleration up to the default animation duration. | |||
| acceleratedDuration = targetState.duration * Math.min(durationFactorX, durationFactorY); | |||
| targetState.duration = Math.max(this._animationDuration, acceleratedDuration); | |||
| targetState.duration = Math.max(this._animationDuration / 2, acceleratedDuration); | |||
There was a problem hiding this comment.
To keep things relative to configured animationDuration, but to speed it up. This effect should be faster than other snap backs.
There was a problem hiding this comment.
Good place for inline comment. We shall never remember after you move on to Netflix
|
Get 'er in!!!! Yes! |
| @@ -68,7 +68,7 @@ define(function(require) { | |||
| } | |||
| map.addInterceptor(new BoundaryInterceptor({ | |||
| centerContent: true, | |||
| mode: 'stop' | |||
| mode: { x: 'stop', y: 'slow' } | |||
There was a problem hiding this comment.
A numerical value might be cooler than 'slow' - very minor thing.
|
+1 after 1 inline comment added. |
|
(waiting on mobile) +10 looked good swiping and CR, all tests pass, etc |
|
+10 looked good swiping on mobile, CR, all tests pass |
|
QA Resource Approval: +1
Merging into master |
charliekump-wf
added a commit
that referenced
this pull request
Feb 7, 2014
Bounce At Boundaries on Swipe
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiping near an AwesomeMap's boundaries, allow the content to
bounce into place to visually convey the boundary condition to the
user. Make this effect available via the BoundaryInterceptor's
'slow' mode.
Update PeekInterceptor to independently manage drags into
boundaries so that the BoundaryInterceptor can use 'slow' mode. This
has the beneficial side-effect of allowing users to drag the first and
last items in the list away from list boundaries and have the content
snap back upon release, thus visually conveying the boundary condition
in that case as well.
Unit Tests
How To +10/QA
@lancefisher-wf
@patkujawa-wf
@shanesizer-wf