/
ChangeLog
18672 lines (13338 loc) · 761 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2020-09-16 Aakash Jain <aakash_jain@apple.com>
[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
https://bugs.webkit.org/show_bug.cgi?id=216566
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.
2020-09-16 Philippe Normand <pnormand@igalia.com>
[Flatpak] webkit-bwrap drive-by cleanups
Rubber-stamped by Adrian Perez de Castro.
* flatpak/webkit-bwrap: Extend lists with tuples, use itertools and map to build the final
command line.
2020-09-16 Philippe Normand <pnormand@igalia.com>
[Flatpak SDK] Cherry-pick Mesa use-after-free fixes
https://bugs.webkit.org/show_bug.cgi?id=216532
Reviewed by Žan Doberšek.
These patches are not in any stable Mesa release yet. The crash is happening on various
tests on both WPE and GTK test bots.
Upstream MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5789
* buildstream/elements/sdk/mesa.bst:
* buildstream/patches/mesa/0001-mesa-rename-_mesa_free_errors_data.patch: Added.
* buildstream/patches/mesa/0002-mesa-add-bool-param-to-_mesa_free_context_data.patch: Added.
* buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch: Added.
2020-09-16 Philippe Normand <pnormand@igalia.com>
[GStreamer] Update Flatpak SDK to 1.18.0
https://bugs.webkit.org/show_bug.cgi?id=216270
Reviewed by Žan Doberšek.
Update to GStreamer 1.18.0, removing the patches now being shipped in this release.
* buildstream/elements/sdk/gst-libav.bst:
* buildstream/elements/sdk/gst-plugins-bad.bst:
* buildstream/elements/sdk/gst-plugins-base.bst:
* buildstream/elements/sdk/gst-plugins-good.bst:
* buildstream/elements/sdk/gst-plugins-ugly.bst:
* buildstream/elements/sdk/gstreamer.bst:
* buildstream/patches/gst-libav-stop-caching-codecs.patch: Removed.
* buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Removed.
* buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Removed.
* buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Removed.
* buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Removed.
* buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Removed.
* buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Removed.
* buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Removed.
* buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Removed.
2020-09-15 David Kilzer <ddkilzer@apple.com>
WebKit should support building with clang ThreadSanitizer enabled
<https://webkit.org/b/216318>
<rdar://problem/31615729>
Reviewed by Darin Adler.
This patch doesn't attempt to resolve every potential false
positive, but makes it easy to build WebKit with TSan enabled.
* Scripts/set-webkit-configuration:
- Add support for --[no-]tsan switches.
* Scripts/webkitdirs.pm:
(determineTSanIsEnabled):
(tsanIsEnabled):
(XcodeOptions):
(generateBuildSystemFromCMakeProject):
- Add support for building with TSan enabled.
* asan/asan.xcconfig: Rename to sanitizer/asan.xcconfig.
* sanitizer/asan.xcconfig: Rename from asan/asan.xcconfig.
- Extract common variables to sanitizer.xcconfig.
* sanitizer/sanitizer.xcconfig: Add.
- Extract common variables from asan.xcconfig.
* sanitizer/tsan.xcconfig: Add.
- Add support for TSan.
2020-09-15 Alex Christensen <achristensen@webkit.org>
Move local storage sync SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216581
Reviewed by Geoffrey Garen.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::clearLocalStorage):
(WTR::TestController::syncLocalStorage):
2020-09-15 Alex Christensen <achristensen@webkit.org>
Move service worker testing timeout setting from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216578
Reviewed by Geoffrey Garen.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setServiceWorkerFetchTimeoutForTesting):
2020-09-15 Fujii Hironori <Hironori.Fujii@sony.com>
[TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=216469
Reviewed by Darin Adler.
Even though UIScriptController class is defined in
TestRunnerShared, UIScriptController::windowIsKey and
UIScriptController::setWindowIsKey methods were defined in the
client modules DRT and WTR. I'd like to make TestRunnerShared a
stand-alone library which doesn't depend on DRT and WTR (Bug
216465).
Add a new class UIScriptControllerCommon to host the common
methods by renaming UIScriptController.cpp.
* DumpRenderTree/CMakeLists.txt:
* TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::windowIsKey const):
(WTR::UIScriptController::setWindowIsKey):
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/UIScriptControllerCommon.cpp: Renamed from Tools/WebKitTestRunner/UIScriptController.cpp.
(WTR::UIScriptControllerCommon::windowIsKey const):
(WTR::UIScriptControllerCommon::setWindowIsKey):
* WebKitTestRunner/UIScriptControllerCommon.h: Added.
(WTR::UIScriptControllerCommon::UIScriptControllerCommon):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
* WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::UIScriptControllerCocoa):
* WebKitTestRunner/gtk/UIScriptControllerGtk.h:
(WTR::UIScriptControllerGtk::UIScriptControllerGtk):
* WebKitTestRunner/win/UIScriptControllerWin.h:
(WTR::UIScriptControllerWin::UIScriptControllerWin):
* WebKitTestRunner/wpe/UIScriptControllerWPE.h:
2020-09-15 Sam Weinig <weinig@apple.com>
Remove runtime setting for enabling/disabling the fetch API
https://bugs.webkit.org/show_bug.cgi?id=216519
Reviewed by Alex Christensen.
Remove runtime setting for enabling/disabling the fetch API. There is no
reason one needs to disable it now and it has been on by default for
a long enough time.
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
2020-09-15 Jonathan Bedard <jbedard@apple.com>
[webkitscmpy] Add Contributor object
https://bugs.webkit.org/show_bug.cgi?id=216402
<rdar://problem/68702680>
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: Added.
(Contributor): Object mapping a contributor by name to their associated email addresses.
(Contributor.clear): Clear the in-memory cache of Contributor objects.
(Contributor.from_scm_log): Find or generate a Contributor object given a commit log line from
an SCM tool.
(Contributor.__init__):
(Contributor.email): Return a single email for a Contributor.
(Contributor.__repr__):
(Contributor.__hash__):
(Contributor.__cmp__):
(Contributor.__eq__):
(Contributor.__ne__):
(Contributor.__lt__):
(Contributor.__le__):
(Contributor.__gt__):
(Contributor.__ge__):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py: Added.
(TestContributor):
(TestContributor.test_git_log):
(TestContributor.test_svn_log):
(TestContributor.test_svn_patch_by_log):
(TestContributor.test_author_mapping):
(TestContributor.test_email_mapping):
(TestContributor.test_invalid_log):
(TestContributor.test_comparison):
(TestContributor.test_string_comparison):
(TestContributor.test_hash):
(TestContributor.test_sorting):
2020-09-15 Sam Weinig <weinig@apple.com>
Remove runtime setting for enabling/disabling custom elements
https://bugs.webkit.org/show_bug.cgi?id=216518
Reviewed by Tim Horton.
Remove runtime setting for enabling/disabling custom elements. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
2020-09-15 Jonathan Bedard <jbedard@apple.com>
[webkitscmpy] Add default_branch for local SCM repositories
https://bugs.webkit.org/show_bug.cgi?id=216422
<rdar://problem/68735897>
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.default_branch): Query the local checkout for the default branch.
(Git):
(Git.branches): Strip "remotes/origin/" from branch names.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.default_branch):
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.default_branch): The default svn branch is always 'trunk'.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branches):
(TestGit.test_tags):
(TestGit):
(TestGit.test_default_branch):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
(TestSvn.test_tags):
(TestSvn):
(TestSvn.test_default_branch):
2020-09-15 Alex Christensen <achristensen@webkit.org>
Move WKContextClearCachedCredentials SPI to WKWebsiteDataStoreClearCachedCredentials
https://bugs.webkit.org/show_bug.cgi?id=216513
Reviewed by Chris Dumez.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
2020-09-15 Alex Christensen <achristensen@webkit.org>
Remove unused plumbing for setting whether the storage access API is enabled
https://bugs.webkit.org/show_bug.cgi?id=216516
Reviewed by Youenn Fablet.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
2020-09-15 Alex Christensen <achristensen@webkit.org>
Move WebSocket TLS bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216509
Reviewed by Youenn Fablet.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::setAllowsAnySSLCertificate):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::setAllowsAnySSLCertificate):
2020-09-15 Rob Buis <rbuis@igalia.com>
Convert runtime flag to setting for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=215610
Reviewed by Youenn Fablet.
Remove lazy image loading runtime flag.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
2020-09-15 Angelos Oikonomopoulos <angelos@igalia.com>
run-jsc-stress-tests: handle remotes that are down on startup
https://bugs.webkit.org/show_bug.cgi?id=216357
Reviewed by Yusuke Suzuki.
Previously, the GNU parallel runner would needlessly fail to run if a
remote host was down on startup, as it used forEachRemote for the
preparatory steps (which would instafail on error).
Change forEachRemote to (optionally) recover from failure by removing
the remote host from the array. This also handles the case where a
remote unexpectedly comes up during a test run (by not picking it up).
* Scripts/run-jsc-stress-tests:
2020-09-15 Youenn Fablet <youenn@apple.com>
End of media capture should not be reported before 3 seconds of the start of capture
https://bugs.webkit.org/show_bug.cgi?id=216415
Reviewed by Eric Carlson.
* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
Add a notCapturing boolean and wait for the notification before going back to the capturing page.
Decrease delay to 1 second to make the test run faster.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Make sure to set media capture state delay to zero.
2020-09-14 Sam Weinig <weinig@apple.com>
Remove runtime setting for enabling/disabling ShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=216511
Reviewed by Ryosuke Niwa.
Remove runtime setting for enabling/disabling ShadowDOM. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
2020-09-14 Jonathan Bedard <jbedard@apple.com>
[webkitcorepy] AutoInstaller should work with HomeBrew Python
https://bugs.webkit.org/show_bug.cgi?id=216496
<rdar://problem/68864294>
Rubber-stamped by Brady Eidson.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version.
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Set prefix to empty for HomeBrew python installs.
2020-09-14 Aakash Jain <aakash_jain@apple.com>
Add unit-tests for triggered_by key in ews config
https://bugs.webkit.org/show_bug.cgi?id=216487
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/loadConfig_unittest.py:
(ConfigDotJSONTest.get_config): Method to read config.json
(ConfigDotJSONTest.test_schduler_contains_valid_builder_name): Ensure that scheduler references a valid builder.
(ConfigDotJSONTest.test_single_builder_for_triggerable_scheduler): Ensure that every Triggerable scheduler references a single builder.
(ConfigDotJSONTest.test_incorrect_triggered_by): Ensure that triggered_by key is correct. Verify by matching that
the builder for the triggered_by scheduler actually triggers current builder.
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResults.test_clean_tree_exceed_failure_limit_with_triggered_by):
2020-09-14 Alex Christensen <achristensen@webkit.org>
Move cookie flushing SPI from WKProcessPool to WKHTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=216493
Reviewed by Chris Dumez.
* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
(TEST):
2020-09-14 Jonathan Bedard <jbedard@apple.com>
[webkitcorepy] Disable AutoInstaller with environment variable (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=216396
<rdar://problem/68680933>
Unreviewed follow-up fix.
r267019 accidently landed without the support of r267019.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version.
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall.enabled): Add False and No to the list of environment variables which resolve to 'False'.
(AutoInstall.set_directory): Use AutoInstall.log instead of print(...).
2020-09-14 Fujii Hironori <Hironori.Fujii@sony.com>
[WinCairo][MediaFoundation] r264188 introduced linker warning: LNK4199: /DELAYLOAD:mf.dll ignored; no imports found from mf.dll
https://bugs.webkit.org/show_bug.cgi?id=214170
Reviewed by Alex Christensen.
* TestWebKitAPI/PlatformWin.cmake:
2020-09-14 Fujii Hironori <Hironori.Fujii@sony.com>
[TestRunnerShared] Make UIScriptContext not directly call UIScriptController::create which are defined in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=216470
Reviewed by Simon Fraser.
UIScriptContext constructor directly called
UIScriptController::create which are defined in DRT and WTR. I'd
like to make TestRunnerShared as a stand alone library which
doesn't depend on DRT and WTR (Bug 216465). Make UIScriptContext
take a factory function to create UIScriptController.
* DumpRenderTree/TestRunner.cpp:
(TestRunner::runUIScript):
* DumpRenderTree/TestRunner.h:
* TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::UIScriptContext):
* TestRunnerShared/UIScriptContext/UIScriptContext.h:
* TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp:
(WTR::UIScriptController::create): Deleted.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::runUISideScript):
2020-09-14 Jonathan Bedard <jbedard@apple.com>
[webkitcorepy] Log autoinstall details even without a logger configured
https://bugs.webkit.org/show_bug.cgi?id=216480
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version.
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Use AutoInstall.log instead of logging.
(AutoInstall):
(AutoInstall.log): Check log to see if a logger is configured, if one is not,
output the message to stderr instead.
2020-09-14 Aakash Jain <aakash_jain@apple.com>
[EWS] Layout testers can go in an infinite RETRY loop when there are 30+ failures on trunk
https://bugs.webkit.org/show_bug.cgi?id=203698
<rdar://problem/66157544>
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(ConfigureBuild.__init__): Added triggerred_by key.
(ConfigureBuild.start): Set triggers property only if it is not already set (by the build who triggerred this build).
(Trigger.__init__): Added include_revision parameter, it would be False while triggerring builder, so that builder
can use ToT instead of the specific revision.
Also added triggers, so that when the tester trigger the builder, it can explicitly specify only to trigger it back and
nothing else.
(Trigger.propertiesToPassToTriggers): Pass ews_revision and triggers properties to triggered builds appropriately.
(AnalyzeLayoutTestsResults.retry_build): Trigger the parent build if triggered_by is specified.
* BuildSlaveSupport/ews-build/config.json: Added triggered_by key.
* BuildSlaveSupport/ews-build/factories.py: Updated to handle triggered_by key.
* BuildSlaveSupport/ews-build/loadConfig.py: Ditto.
* BuildSlaveSupport/ews-build/loadConfig_unittest.py:
* BuildSlaveSupport/ews-build/factories_unittest.py:
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): If the build is retried, ensure that the status-bubble is orange.
(StatusBubble._most_recent_failure_message): Display the retry message from analyze-layout-tests-results step in the status-bubble.
2020-09-14 Jonathan Bedard <jbedard@apple.com>
[webkitcorepy] Disable AutoInstaller with environment variable
https://bugs.webkit.org/show_bug.cgi?id=216396
<rdar://problem/68680933>
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall):
(AutoInstall.enabled): Check DISABLE_WEBKITCOREPY_AUTOINSTALLER to see if the autoinstaller
has been explicitly disabled.
(AutoInstall.set_directory): Early exit if the autoinstaller is explicitly disabled.
(AutoInstall.find_module):
(AutoInstall.enable): Deleted.
(AutoInstall.disable): Deleted.
2020-09-14 Philippe Normand <pnormand@igalia.com>
[Flatpak SDK] Migration to SDK 0.3 branch
https://bugs.webkit.org/show_bug.cgi?id=216073
Reviewed by Adrian Perez de Castro.
As this new SDK branch is based on the FDO 20.08 SDK which breaks ABI, existing WebKit
builds done with the 0.2 branch will no longer be usable. Developers are advised to remove
their WebKitBuild/{GTK,WPE} local directories after updating to 0.3.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): Since we now ship Mesa directly in the SDK we can easily
configure the prefix where DRI modules are installed. This is now the same as in the JHBuild
sysroot.
* flatpak/flatpakutils.py:
(WebkitFlatpak.__init__): Bump to 0.3 branch. Also un-hardcode host platform architecture so
that we can more easily add aarch64 bots later.
(WebkitFlatpak._get_packages): The GL extension is no longer needed because Mesa is shipped
directly within our SDK now. Also install the rust extension, which is useful eg when doing
development with gst-build.
* flatpak/webkit-bwrap: Add rustc path in PATH.
2020-09-13 Alexey Proskuryakov <ap@apple.com>
Move block-spammers tool to python 3
https://bugs.webkit.org/show_bug.cgi?id=216457
Reviewed by Sam Weinig.
* Scripts/block-spammers: Updated for new print() and translate() syntax, and
moved from raw_input() to input().
2020-09-13 Wenson Hsieh <wenson_hsieh@apple.com>
Add a key to the text manipulation userInfo dictionary indicating whether the translated item is on-screen
https://bugs.webkit.org/show_bug.cgi?id=216452
<rdar://problem/68785397>
Reviewed by Darin Adler.
Adjust an existing test so that it adds a fourth text paragraph with 2000px of top margin, and also
programmatically scrolls after loading the page so that only this last paragraph is visible. We expect the
metadata to indicate that none of the other tokens except this last one has a value of `YES` for
`_WKTextManipulationTokenUserInfoVisibilityKey`.
* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
2020-09-12 Darin Adler <darin@apple.com>
Send TestRendered event after running a test but before dumping
https://bugs.webkit.org/show_bug.cgi?id=216428
Reviewed by Sam Weinig.
* DumpRenderTree/CMakeLists.txt: Added the new files and directories.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Ditto.
* DumpRenderTree/PlatformWin.cmake: Temporarily disable precompiled headers
on WinCairo since they were not working properly with JSBasics.cpp.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate readyToDumpState]): Added. Calls sendTestRenderedEvent.
(-[FrameLoadDelegate processWork:]): Call readyToDumpState.
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Ditto.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(readyToDumpState): Added. Calls sendTestRenderedEvent.
(FrameLoadDelegate::processWork): Call readyToDumpState.
(FrameLoadDelegate::locationChangeDone): Ditto.
* TestRunnerShared/Bindings/JSBasics.cpp: Added.
(WTR::JSValueMakeBooleanOrNull): Moved from JSWrappable.h.
(WTR::JSValueToNullableBoolean): Ditto.
(WTR::JSValueMakeStringOrNull): Ditto.
(WTR::createJSString): Ditto.
(WTR::makeValue): Ditto.
(WTR::objectProperty): Ditto.
(WTR::setProperty): Added. Sets a named property value to a boolean.
(WTR::call): Moved from JSWrappable.h.
(WTR::callConstructor): Added. Gets a global constructor and calls it.
* TestRunnerShared/Bindings/JSBasics.h: Added. Declares the above functions.
* TestRunnerShared/Bindings/JSWrappable.h:
(WTR::JSValueMakeBooleanOrNull): Deleted.
(WTR::JSValueToNullableBoolean): Deleted.
(WTR::JSValueMakeStringOrNull): Deleted.
(WTR::createJSString): Deleted.
(WTR::makeValue): Deleted.
(WTR::objectProperty): Deleted.
(WTR::call): Deleted.
(WTR::hasRefTestWaitAttribute): Deleted.
* TestRunnerShared/Bindings/JSWrapper.h: Updated includes.
* TestRunnerShared/ReftestFunctions.cpp: Added.
(WTR::sendTestRenderedEvent): Added. Creates and dispatches a TestRendered event.
(WTR::hasReftestWaitAttribute): Moved from JSWrappable.h and renamed to use a
lowercase T since that's how web-platform-tests names things.
* TestRunnerShared/ReftestFunctions.h: Added. Declares the above functions.
* WebKitTestRunner/CMakeLists.txt: Added the new files and directories.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::frameDidChangeLocation): Call sendTestRenderedEvent
before calling dumpAfterWaitAttributeIsRemoved.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added a
missing include of "config.h" to fix build failures I was seeing. An alternative,
since this is a Cocoa-only source file, would be to put config.h into a
precompiled prefix header.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Ditto.
* WebKitTestRunner/PlatformWin.cmake: Temporarily disable precompiled headers
on WinCairo since they were not working properly with JSBasics.cpp.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added the new
files and directories.
2020-09-12 Darin Adler <darin@apple.com>
REGRESSION (r266817): ASSERTION FAILED: injectedBundle.isTestRunning() on imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html
https://bugs.webkit.org/show_bug.cgi?id=216440
[GTK] imported/w3c/web-platform-tests/service-workers/service-worker/svg-target-reftest.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=210375
Reviewed by Sam Weinig.
Did some hardening of the reftest-wait mechanism in WebKitTestRunner.
We can later do the same in DumpRenderTree if the same problem comes up there,
but at this time I don't have a test that reproduces the issue there so not
changing it for now. Don't want to add speculative code without testing it.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::hasRefTestWaitAttribute): Changed to take a WKBundlePageRef instead of
a InjectedBundlePage&.
(WTR::dumpAfterWaitAttributeIsRemoved): Changed to take a WKBundlePageRef.
Added code to handle cases where an explicit dump occurs while we are waiting
for the attribute to be removed. Identify the page with the WKBundlePageRef,
which can be retained/released.
(WTR::InjectedBundlePage::frameDidChangeLocation): Check page for null
instead of indirectly checking by asking if the pageCount is 0. Also pass
a WKBundlePageRef in to dumpAfterWaitAttributeIsRemoved.
2020-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] REGRESSION(r266815): Several GTK API tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=216361
Reviewed by Adrian Perez de Castro.
Unskip tests that are now passing.
* TestWebKitAPI/glib/TestExpectations.json:
2020-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Timeouts after reftest-wait class enablement in r266817
https://bugs.webkit.org/show_bug.cgi?id=216397
Reviewed by Adrian Perez de Castro.
Tests are timing out because dumpAfterWaitAttributeIsRemoved() is called recursively from a WebCore timer, not
allowing other sources with lower priority like display refresh monitor one to be run. This patch simply adds a
1 millisecond delay between dumpAfterWaitAttributeIsRemoved tries to allow other sources to be run in the main
loop.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpAfterWaitAttributeIsRemoved):
2020-09-11 Sihui Liu <sihui_liu@apple.com>
Assertion Failed: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion
https://bugs.webkit.org/show_bug.cgi?id=216376
Reviewed by Tim Horton.
After completing each task, we will end UIScript if there is no remaining task. We need to make sure task is
completed asynchronously, otherwise it may finish before other tasks in the same script are scheduled as
script ends early.
* WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
* WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::completeTaskAsynchronouslyAfterActivityStateUpdate):
(WTR::UIScriptControllerCocoa::removeViewFromWindow):
(WTR::UIScriptControllerCocoa::addViewToWindow):
2020-09-11 Frank Yang <guowei_yang@apple.com>
Adding myself as committer
https://bugs.webkit.org/show_bug.cgi?id=216419
Reviewed by Myles C. Maxfield.
Adding myself as a committer.
* Scripts/webkitpy/common/config/contributors.json:
adding committer status to my name.
2020-09-11 Aakash Jain <aakash_jain@apple.com>
Disable gtk-api queue temporarily
https://bugs.webkit.org/show_bug.cgi?id=216411
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/config.json:
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2020-09-11 Alex Christensen <achristensen@webkit.org>
Move _setCookieAcceptPolicy to WKHTTPCookieStore
https://bugs.webkit.org/show_bug.cgi?id=216375
Reviewed by Geoffrey Garen.
* TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::generatePageConfiguration):
2020-09-11 Zhifei Fang <zhifei_fang@apple.com>
Strip Quotes for run-jsc-stress-tests --model arg
https://bugs.webkit.org/show_bug.cgi?id=216417
Reviewed by Jonathan Bedard.
* Scripts/run-jsc-stress-tests:
2020-09-11 Sihui Liu <sihui_liu@apple.com>
REGRESSION(r266634): WKThumbnailViewResetsViewStateWhenUnparented is flaky
https://bugs.webkit.org/show_bug.cgi?id=216258
<rdar://problem/68515242>
Reviewed by Tim Horton.
r266634 makes activity state changes dispatched after existing CA transaction is committed, which delays update
of page state in web process.
* TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView waitUntilActivityStateUpdateDone]):
2020-09-10 Chris Dumez <cdumez@apple.com>
Unreviewed, reverting r266842 and r266883.
Causes some assertions to be hit in debug builds
Reverted changesets:
"Some WebAudio tests give different output on different
machines"
https://bugs.webkit.org/show_bug.cgi?id=216371
https://trac.webkit.org/changeset/266842
"Unreviewed Windows build fix after r266842."
https://trac.webkit.org/changeset/266883
2020-09-09 Brian Burg <bburg@apple.com>
Web Inspector: _WKInspectorDelegate should be attached to _WKInspector not WKWebView
https://bugs.webkit.org/show_bug.cgi?id=215961
Reviewed by Devin Rousso.
Refactor the test to set the _WKInspectorDelegate correctly.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm.
(-[InspectorDelegate inspectorDidEnableBrowserDomain:]):
(-[InspectorDelegate inspectorDidDisableBrowserDomain:]):
(-[UIDelegate _webView:didAttachLocalInspector:]):
(TEST):
2020-09-10 Devin Rousso <drousso@apple.com>
Web Inspector: modernize generated backend protocol code
https://bugs.webkit.org/show_bug.cgi?id=216302
<rdar://problem/68547649>
Reviewed by Brian Burg.
* TestWebKitAPI/Tests/WTF/JSONValue.cpp:
2020-09-10 Sihui Liu <sihui_liu@apple.com>
REGRESSION (r266634): [macOS release] 4 layout tests became flaky failures
https://bugs.webkit.org/show_bug.cgi?id=216275
<rdar://problem/68515242>
Reviewed by Tim Horton.
* WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::removeViewFromWindow):
(WTR::UIScriptControllerCocoa::addViewToWindow):
2020-09-10 Chris Dumez <cdumez@apple.com>
Some WebAudio tests give different output on different machines
https://bugs.webkit.org/show_bug.cgi?id=216371
Reviewed by Alex Christensen.
Update DRT / WRT to hardcode the hardware sample rate to 44100 so that Web Audio
test have the same output on different hardware.
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
2020-09-10 Kate Cheney <katherine_cheney@apple.com>
Clean up App-Bound Domains code to only compile for iOS with its own macro
https://bugs.webkit.org/show_bug.cgi?id=215027
<rdar://problem/63688232>
Reviewed by Darin Adler.
Replace check for IOS_FAMILY with more aptly named APP_BOUND_DOMAINS
macro.
* TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2020-09-10 Jonathan Bedard <jbedard@apple.com>
[webkitscmpy] Add tags, branches queries on local repositories
https://bugs.webkit.org/show_bug.cgi?id=216333
<rdar://problem/68603047>
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git):
(Git.branches): List all branches associated with a local repository.
(Git.tags): List all tags associated with a local repository.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm):
(Scm.branches):
(Scm.tags):
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn):
(Svn.list):
(Svn.branches): List all branches associated with a local repository.
(Svn.tags): List all branches associated with a local repository.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git.__init__): Add 'git branch -a' and 'git tag', change default branch.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
(Svn.__init__): Add 'svn list ^/*' commands.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branch): Change default branch to main.
(TestGit):
(TestGit.test_branches):
(TestGit.test_tags):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
(TestSvn):
(TestSvn.test_branches):
(TestSvn.test_tags):
2020-09-10 Diego Pino Garcia <dpino@igalia.com>
[GTK] Unreviewed test gardening. Add tests timing out after r266815.
Also update test expectations to remove test passing after r266721.
* TestWebKitAPI/glib/TestExpectations.json:
2020-09-10 Darin Adler <darin@apple.com>
webkit-test-runner: Add support for the reftest-wait class name
https://bugs.webkit.org/show_bug.cgi?id=186045
Reviewed by Antti Koivisto.
Rather than implement this in a JavaScript test running, built this
support into the two test runner tools.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate dumpAfterWaitAttributeIsRemoved:]): Added. Use to keep
polling until the reftest-wait attribute is gone.
(-[FrameLoadDelegate processWork:]): Call dumpAfterWaitAttributeIsRemoved
instead of calling dump directly.
(-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Ditto.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(dumpAfterWaitAttributeIsRemoved): Added. Use to keep polling until the
reftest-wait attribute is gone.
(FrameLoadDelegate::processWork): Call dumpAfterWaitAttributeIsRemoved
intead of calling dump directly.
(FrameLoadDelegate::locationChangeDone): Ditto.
* TestRunnerShared/Bindings/JSWrappable.h: Added helper functions for
dealing with JavaScript strings, values, properties, and function calls.
Also added a hasRefTestWaitAttribute function. All of these could probably
find a better home, but for now it was nice to not have to add a new source file.
* TestRunnerShared/Bindings/JSWrapper.h:
(WTR::setProperty): Use the new createJSString. A lot of other TestRunner code
could be tightened up by using these functions, but didn't do that for now.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::hasRefTestWaitAttribute): Added. Calls the other overload of this.
(WTR::dumpAfterWaitAttributeIsRemoved): Added. Use to keep polling until
the reftest-wait attribute is gone.
(WTR::InjectedBundlePage::frameDidChangeLocation): Call
dumpAfterWaitAttributeIsRemoved instead of done.
2020-09-09 Ryosuke Niwa <rniwa@webkit.org>
Simplify OptionSet::set
https://bugs.webkit.org/show_bug.cgi?id=216335
Reviewed by Said Abou-Hallawa.
Added a unit test for OptionSet::set.
* TestWebKitAPI/Tests/WTF/OptionSet.cpp:
(WTF_OptionSet.Set):
2020-09-09 Fujii Hironori <Hironori.Fujii@sony.com>
Add Visual Studio debugger custom views for NeverDestroyed, LazyNeverDestroyed, VectorBufferBase, Optional, and StringView
https://bugs.webkit.org/show_bug.cgi?id=216304
Reviewed by Don Olmstead.
* VisualStudio/WebKit.natvis:
2020-09-09 Lauro Moura <lmoura@igalia.com>
kill-old-processes: Avoid calling kill command with empty string with GNU xargs
https://bugs.webkit.org/show_bug.cgi?id=216323
Reviewed by Darin Adler.
* BuildSlaveSupport/kill-old-processes:
(main):
2020-09-09 Aakash Jain <aakash_jain@apple.com>
ews might mark build as successful if tests fail to run
https://bugs.webkit.org/show_bug.cgi?id=215944
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeLayoutTestsResults.retry_build):
(AnalyzeLayoutTestsResults.start):
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResults.test_test_fail_to_runs):
2020-09-09 Brady Eidson <beidson@apple.com>
Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and https://bugs.webkit.org/show_bug.cgi?id=216317
Reviewed by Geoffrey Garen.
* TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):
2020-09-09 Angelos Oikonomopoulos <angelos@igalia.com>
run-jsc-stress-test: fix escaping for --gnu-parallel-runner
https://bugs.webkit.org/show_bug.cgi?id=215887
Reviewed by Keith Miller.
Change the GNU parallel invocation to use double quotes, to be consistent with
the invocation of ssh by the make runner. This should unbreak
--gnu-parallel-runner after the fix in r265204.
* Scripts/run-jsc-stress-tests:
2020-09-09 Aakash Jain <aakash_jain@apple.com>
Add Philippe Normand to EWS emails unsubscribe list
Unreviewed.
* BuildSlaveSupport/ews-build/emails.json:
2020-09-08 Lauro Moura <lmoura@igalia.com>
kill-old-processes: Remove stale Apache2 shm segments
https://bugs.webkit.org/show_bug.cgi?id=216068
Reviewed by Alexey Proskuryakov.
Based on original patch by Diego Pino Garcia.
When Apache2 terminates abruptely, it may not free up allocated shared
memory segments. When later Apache2 is started again, if its pid
matches the pid of orphan shm segments it fails believing there's
already an Apache2 instance running. To avoid this situation, after
killing Apache2 we check for potential orphaned shm segments and
remove them.
If any error happens during the cleanup, log the failure and continue
the script, addressing the issue that caused the initial revert in
r266536.