/
ChangeLog
24316 lines (16828 loc) · 808 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2010-07-09 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fixed Qt symbian/linux-armcc mkspec when configured with -qtlibinfix.
* declarative/declarative.pro: Use QT_LIBINFIX.
2010-07-09 Anders Bakken <agbakken@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Remove superfluous function calls
https://bugs.webkit.org/show_bug.cgi?id=40353
QWebFrame::setUrl() calls ensureAbsoluteUrl() twice. It's better to
store a local variable and reuse this one.
QWebFrame::load(QUrl) calls QWebFrame::load(QNetworkRequest) which in
turn will get the QUrl from the request and make sure it's absolute by
calling ensureAbsoluteUrl() on it.
* Api/qwebframe.cpp:
(QWebFrame::setUrl):
(QWebFrame::load):
2010-07-08 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Simon Hausmann.
[Qt] instance objects created for QObjects are somtimes GC'd
https://bugs.webkit.org/show_bug.cgi?id=40352
Improved the test to check for jsObjects that that are garbage collected.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::):
2010-07-08 Aaron Boodman <aa@chromium.org>
Unreviewed change to fix qt build after c62876.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::addUserStyleSheet):
2010-07-07 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add DRT support for pageProperty etc.
https://bugs.webkit.org/show_bug.cgi?id=41584
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::isPageBoxVisible):
(DumpRenderTreeSupportQt::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportQt::pageProperty):
(DumpRenderTreeSupportQt::addUserStyleSheet):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-07-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41826
Convert BackForwardList to an abstract base class and add BackForwardListImpl
as the concrete implementation of it.
* Api/qwebhistory.cpp:
(QWebHistory::clear):
(QWebHistory::back):
(QWebHistory::forward):
(QWebHistory::goToItem):
(operator>>):
(QWebHistoryPrivate::page):
2010-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Remove unused WEBKIT_VERSION define from qwebpage.cpp
We now use qWebKitVersion()
* Api/qwebpage.cpp:
2010-07-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
Add basic piping for BackForwardControllerClient.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
2010-07-07 Marc Mutz <marc.mutz@kdab.com>
Reviewed by Adam Barth.
[Qt] QWebSettings: Don't leak native pixmaps
When Q_GLOBAL_STATIC gets around to deleting the QHash with the
pixmaps in, the QApplication destructor has already been
completed. This makes it impossible for ~QPixmap to return the
native pixmap to the OS, thus leaking them.
This patch adds a post routine (executed as part of ~QApplication)
that clears the hash so Q_GLOBAL_STATIC's destruction doesn't have
to execute ~QPixmap's anymore.
https://bugs.webkit.org/show_bug.cgi?id=41657
* Api/qwebsettings.cpp:
(earlyClearGraphics): New. Clears the pixmap hash.
(graphics): add earlyClearGraphics as a qAddPostRoutine()
2010-07-06 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by Kenneth Rohde Christiansen.
Client errors should set "WebKitErrorDomain" domain instead of "WebKit" to match Mac.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
2010-07-06 Darin Adler <darin@apple.com>
Fix crash caused by my fix to the Qt build.
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::closeWindow): Release pointer into
a local OwnPtr instead of calling clear. Another fix, probably better,
would be to change OwnPtr::clear to zero out the pointer before deleting,
but that affects many more call sites, so I will do that separately.
2010-07-06 Darin Adler <darin@apple.com>
Fix Qt build.
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::closeWindow): Call clear instead of
calling delete on the result of leakPtr.
2010-06-19 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: js function name was fixed.
dispatchMessageToFrontend -> dispatchMessageFromBackend.
https://bugs.webkit.org/show_bug.cgi?id=40675
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::sendMessageToFrontend):
2010-07-03 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Object property names such as 'background-color' need to be returned in camel
case, i.e. backgroundColor so that JS can reference them. Add support for this
to DumpRenderTreeSupportQt.
https://bugs.webkit.org/show_bug.cgi?id=40445
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertToPropertyName):
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
2010-07-01 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] dump frames in ascending alphabetical order of title
https://bugs.webkit.org/show_bug.cgi?id=41261
Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::getChildHistoryItems):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-07-01 Bea Lam <bea.lam@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Doc improvements for QDeclarativeWebView
* declarative/qdeclarativewebview.cpp:
2010-07-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Create QComboBoxes when clicked and destroy on hide.
https://bugs.webkit.org/show_bug.cgi?id=41451
Currently a QComboBox is created for each RenderMenuList and
it gets destroyed either when the RenderMenuList or the
QWebView (its Qt parent) is destroyed. This cause a crash
when the QWebView is destroyed before the render tree (which
is kept in cache).
This patch aim to destroy the QComboBox as soon as its popup
gets hidden, and likewise, create it only when the popup is
requested to be shown.
It also removes the unneeded reference to the QGraphicsProxyWidget,
destroying the QComboBox automatically destroys its bound
proxywidget.
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopupCombo::hidePopup):
(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::hide):
(WebCore::QtFallbackWebPopup::destroyPopup):
(WebCore::QtFallbackWebPopup::populate):
* WebCoreSupport/QtFallbackWebPopup.h:
2010-07-01 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984
* Api/qwebsettings.cpp:
(graphics):
* Api/qwebsettings.h:
2010-06-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure we catch closed QComboBox popups.
https://bugs.webkit.org/show_bug.cgi?id=39019
The way it works currently is using the QComboBox::show/hidePopup
virtual method to catch popup requests in the middle. There is
some cases however that the popup widget gets closed without
going through the hidePopup method.
This patch adds an event filter to the popup's view to know when
it gets closed and calls hidePopup to call our handling code.
This may get hidePopup called twice but this shouldn't have any
effect.
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo):
(WebCore::QtFallbackWebPopupCombo::eventFilter):
* WebCoreSupport/QtFallbackWebPopup.h:
2010-06-30 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Symbian build fix.
[Qt] Update the def files to link DumpRenderTree.
* symbian/eabi/QtWebKitu.def:
2010-06-30 Samuel Nevala <samuel.nevala@digia.com>
Reviewed by Simon Hausmann.
[Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
https://bugs.webkit.org/show_bug.cgi?id=38720
Load qttest_p4.prf under QTDIR_build.
* tests/tests.pri:
2010-06-29 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::dumpResourceResponseMIMETypes):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
* WebCoreSupport/FrameLoaderClientQt.h:
2010-06-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed Symbian build fix.
[Qt] Update the def file after r61879.
* symbian/eabi/QtWebKitu.def:
2010-06-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QGraphicsWebView crash when calling setScale() before setUrl()
https://bugs.webkit.org/show_bug.cgi?id=40000
Check 'page' before dereference in _q_scaleChanged()
Autotest included.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::_q_scaleChanged):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl):
2010-06-26 Simon Hausmann <hausmann@webkit.org>
[Qt] Prospective build fix for MSVC
In order for the forward declaration of QWebScriptWorldPrivate
to work with QExplicitlySharedDataPointer, then copy constructor
and assignment operators must not be compiler generated, to
avoid them ending up in places where the private class is not
declared.
* Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):
(QWebScriptWorld::operator=):
* Api/qwebscriptworld.h:
2010-06-26 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Support for setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=39564
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setCustomPolicyDelegate):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(drtDescriptionSuitableForTestResult):
(WebCore::navigationTypeToString):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/FrameLoaderClientQt.h:
2010-06-25 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtWebKit crashes if <select>'s render changes in its onchange event
https://bugs.webkit.org/show_bug.cgi?id=41164
QtWebKit crashes if <select>'s renderer changes in its onchange event.
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
2010-06-25 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Support evaluateScriptInIsolatedWorld()
https://bugs.webkit.org/show_bug.cgi?id=40079
Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
Remove QWebScriptWorld from exported headers.
Confine support to DumpRenderTreeSupportQt so that the tests can pass.
* Api/headers.pri:
* Api/qwebframe.cpp:
* Api/qwebframe.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearScriptWorlds):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-06-24 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Symbian build fix.
The QML WebKit integration needs to be part of QtWebKit.sis
* declarative/declarative.pro: Removed non-working deployment.
2010-06-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, Symbian build fix.
[Qt] Update the def file after r61478.
* symbian/eabi/QtWebKitu.def:
2010-06-23 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Doc: Fixed documentation errors.
* docs/qtwebkit-bridge.qdoc:
2010-06-23 Alessandro Portale <alessandro.portale@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Provide the Webkit Qml plugin with a UID3 on Symbian
...otherwise we cannot Symbian sign it.
* declarative/declarative.pro:
2010-06-23 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt package build fix.
When building without build-webkit, set OUTPUT_DIR if necessary, like
in the other .pro files.
* declarative/declarative.pro:
2010-06-22 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with QT_NO_COMBOBOX.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createSelectPopup):
2010-06-21 Robert Hogan <robert@webkit.org>
[Qt] Build fix for Qt on Windows MSVC2008
Unreviewed, build fix.
Fix by Jocelyn Turcotte.
* Api/qwebframe.cpp:
2010-06-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Fix MSVC build.
The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.
* WebCoreSupport/NotificationPresenterClientQt.cpp:
2010-06-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, Symbian build fix.
[Qt] Update the def file with recent new exports.
* symbian/eabi/QtWebKitu.def:
2010-06-21 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix.
[Qt] Fix package builds
Don't use rpath unless we're building inside the trunk.
* declarative/declarative.pro:
2010-06-20 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
The QWebHistory regression fix.
After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.
Use page->goToItem() instead of direct actions on the BackForwardList.
[Qt] REGRESSION(r61207): qwebhistory unit test hangs
https://bugs.webkit.org/show_bug.cgi?id=40672
* Api/qwebhistory.cpp:
(QWebHistory::back):
(QWebHistory::forward):
(QWebHistory::goToItem):
* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::init):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
2010-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718
Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.
* Api/qwebkitplatformplugin.h:
(QWebSelectData::~QWebSelectData):
(QWebSelectMethod::~QWebSelectMethod):
(QWebNotificationData::~QWebNotificationData):
* WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper):
(WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper):
(WebCore::SelectInputMethodWrapper::show):
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
* examples/platformplugin/qwebkitplatformplugin.h:
(QWebSelectData::~QWebSelectData):
(QWebSelectMethod::~QWebSelectMethod):
(QWebNotificationData::~QWebNotificationData):
2010-06-19 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Hausmann.
Bridge documentation: some snippets have the wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=40717
Fixed code snippets
* docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
(wrapInFunction):
2010-06-02 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
[Qt] Support evaluateScriptInIsolatedWorld()
https://bugs.webkit.org/show_bug.cgi?id=40079
* Api/headers.pri:
* Api/qwebframe.cpp:
(QWebFrame::evaluateScriptInIsolatedWorld):
* Api/qwebframe.h:
* Api/qwebscriptworld.cpp: Added.
(QWebScriptWorld::QWebScriptWorld):
(QWebScriptWorld::world):
(QWebScriptWorld::~QWebScriptWorld):
* Api/qwebscriptworld.h: Added.
* Api/qwebscriptworld_p.h: Added.
(QWebScriptWorldPrivate::QWebScriptWorldPrivate):
(QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-06-19 Olivier Goffart <olivier.goffart@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compilation in QWebPagePrivate::timerEvent with clang
https://bugs.webkit.org/show_bug.cgi?id=40714
QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang
QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See http://llvm.org/bugs/show_bug.cgi?id=6840
This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.
* Api/qwebpage.cpp:
(QWebPagePrivate::timerEvent):
2010-06-19 Mirko Damiani <mirko@develer.com>
Reviewed by Simon Hausmann.
[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
https://bugs.webkit.org/show_bug.cgi?id=40662
The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.
* Api/qwebframe.cpp:
(QWebFrame::print):
2010-06-18 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.
https://bugs.webkit.org/show_bug.cgi?id=33333
Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
* Api/qwebpage.cpp:
(QWebPage::javaScriptConsoleMessage):
2010-06-18 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix documentation for the declarative module import.
* declarative/qdeclarativewebview.cpp:
2010-06-18 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Simon Hausmann.
Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
2010-06-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Antti Koivisto.
REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830
When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
2010-06-18 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Change the target path to QtWebKit.
* declarative/declarative.pro:
2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
2010-06-17 Robert Hogan <robert@webkit.org>
[Qt] Build fix
Unreviewed.
Remove includes in qdeclarativewebview*.* that rely on an installation
of QtWebKit.
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
2010-06-17 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333
Broke inspector tests on Qt
* Api/qwebpage.cpp:
(QWebPage::javaScriptConsoleMessage):
2010-06-17 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.
https://bugs.webkit.org/show_bug.cgi?id=33333
Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
* Api/qwebpage.cpp:
(QWebPage::javaScriptConsoleMessage):
2010-06-17 Jesus Sanchez-Palencia <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
[Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902
Add viewport meta tag support to QtWebKit API layer.
This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.
* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.
* Api/qwebpage.cpp:
(QWebPage::viewportChangeRequested):
* Api/qwebpage_p.h:
Added class QtViewportHintsPrivate.
* Api/qwebpage.h:
(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
* WebCoreSupport/PageClientQt.h:
The PageClient is now responsible for providing the right window rect.
2010-06-17 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream the WebKit QML integration plugin
https://bugs.webkit.org/show_bug.cgi?id=40050
Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.
* declarative/declarative.pro: Added.
* declarative/plugin.cpp: Added.
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp: Added.
(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):
* declarative/qdeclarativewebview_p.h: Added.
(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):
* declarative/qmldir: Added.
* docs/qtwebkit.qdocconf:
2010-06-17 Mark Brand <mabrand@mabrand.nl>
Reviewed by Simon Hausmann.
[Qt] use "win32-g++*" scope to match all MinGW makespecs
The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.
* Api/DerivedSources.pro:
2010-05-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann, Antti Koivisto
[Qt] Add internal Qt Api to configure repaint throttling parameters.
https://bugs.webkit.org/show_bug.cgi?id=38401
* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
2010-06-16 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after setResizesToContents(true)
When calling setPage() after setResizesToContents, the value of the property wasn't propagated
to the page client. Therefore the visible rect for the tiled backing store was incorrect.
Simply move the variable assignment into updateResizesToContentsForPage(), which is always called.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebView::setResizesToContents):
2010-06-16 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Swap WebGL and SiteSpecificQuirks attributes in the QWebSettings
enum, to allow for binary compatibility with qtwebkit-2.0, where
WebGL is not in the settings but SiteSpecificQuirks will be.
* Api/qwebsettings.h:
2010-06-15 Darin Adler <darin@apple.com>
Fix build.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::shouldClose): Call loader()->shouldClose().
2010-06-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Rename NotificatioIconWrapper to NotificationWrapper
https://bugs.webkit.org/show_bug.cgi?id=40571
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
* WebCoreSupport/NotificationPresenterClientQt.h:
(WebCore::NotificationWrapper::~NotificationWrapper):
2010-06-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, Symbian build fix.
[Qt] Update the def file with recent new exports.
* symbian/eabi/QtWebKitu.def:
2010-06-15 Yael Aharon <yael.aharon@nokia.com>
Unreviewed.
Fix typo in reviewer name in r61187
2010-06-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Fraser.
[Qt] Build fix for Qt minimal after r61121
https://bugs.webkit.org/show_bug.cgi?id=40624
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):