/
ChangeLog
13686 lines (10977 loc) · 461 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2017-11-02 Filip Pizlo <fpizlo@apple.com>
AI does not correctly model the clobber case of ArithClz32
https://bugs.webkit.org/show_bug.cgi?id=179188
Reviewed by Michael Saboff.
* stress/arith-clz32-effects.js: Added.
(foo):
(valueOf):
2017-11-01 Michael Saboff <msaboff@apple.com>
Integer overflow in code generated by LoadVarargs processing in DFG and FTL.
https://bugs.webkit.org/show_bug.cgi?id=179140
Reviewed by Saam Barati.
New regression test.
* stress/regress-179140.js: Added.
(testWithoutFTL):
(testWithFTL):
2018-01-03 Michael Saboff <msaboff@apple.com>
Disable SharedArrayBuffers from Web API
https://bugs.webkit.org/show_bug.cgi?id=181266
Reviewed by Saam Barati.
Disabled SharedArrayBuffer tests.
* stress/SharedArrayBuffer-opt.js:
* stress/SharedArrayBuffer.js:
* stress/array-buffer-byte-length.js:
* stress/atomics-add-uint32.js:
* stress/atomics-known-int-use.js:
* stress/atomics-neg-zero.js:
* stress/atomics-store-return.js:
* stress/lars-sab-workers.js:
* stress/regress-159779-1.js:
* stress/regress-159779-2.js:
* stress/regress-170473.js:
* test262.yaml:
2017-11-27 JF Bastien <jfbastien@apple.com>
JavaScript rest function parameter with negative index leads to bad DFG abstract interpretation
https://bugs.webkit.org/show_bug.cgi?id=180051
<rdar://problem/35614371>
Reviewed by Saam Barati.
* stress/rest-parameter-negative.js: Added.
(__f_5484):
(catch):
(__f_5485):
(__v_22598.catch):
2017-10-19 Mark Lam <mark.lam@apple.com>
Stringifier::appendStringifiedValue() is missing an exception check.
https://bugs.webkit.org/show_bug.cgi?id=178386
<rdar://problem/35027610>
Reviewed by Saam Barati.
* stress/regress-178386.js: Added.
2017-10-18 Mark Lam <mark.lam@apple.com>
The compiler should always register a structure when it adds its transitionWatchPointSet.
https://bugs.webkit.org/show_bug.cgi?id=178420
<rdar://problem/34814024>
Reviewed by Saam Barati and Filip Pizlo.
* stress/regress-178420.js: Added.
(new.Array.10000.map):
2017-09-06 Mark Lam <mark.lam@apple.com>
constructGenericTypedArrayViewWithArguments() is missing an exception check.
https://bugs.webkit.org/show_bug.cgi?id=176485
<rdar://problem/33898874>
Reviewed by Keith Miller.
* stress/regress-176485.js: Added.
2017-10-09 Oleksandr Skachkov <gskachkov@gmail.com>
Safari 10 /11 problem with if (!await get(something)).
https://bugs.webkit.org/show_bug.cgi?id=176685
Reviewed by Saam Barati.
* stress/async-await-basic.js:
(awaitEpression.async):
* stress/async-await-syntax.js:
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode):
2017-09-27 Michael Saboff <msaboff@apple.com>
REGRESSION(210837): RegExp containing failed non-zero minimum greedy groups incorrectly match
https://bugs.webkit.org/show_bug.cgi?id=177570
Reviewed by Filip Pizlo.
New regression test.
* stress/regress-177570.js: Added.
2017-09-27 Mark Lam <mark.lam@apple.com>
JSArray::canFastCopy() should fail if the source and destination arrays are the same.
https://bugs.webkit.org/show_bug.cgi?id=177584
<rdar://problem/34463903>
Reviewed by Saam Barati.
* stress/regress-177584.js: Added.
(assertEqual):
(Array.prototype.Symbol.species):
2017-08-30 Saam Barati <sbarati@apple.com>
semicolon is being interpreted as an = in the LiteralParser
https://bugs.webkit.org/show_bug.cgi?id=176114
Reviewed by Oliver Hunt.
* stress/jsonp-literal-parser-semicolon-is-not-assignment.js: Added.
* stress/resources/literal-parser-test-case.js: Added.
2017-08-17 JF Bastien <jfbastien@apple.com>
WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>
Reviewed by Saam Barati.
Add a regression directory for WebAssembly tests.
* wasm.yaml:
* wasm/regress/175693.js: Added.
(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):
* wasm/regress/175693.wasm: Added.
2017-08-09 Caitlin Potter <caitp@igalia.com>
Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970
Reviewed by Saam Barati.
Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.
The following become legal in JSC:
```
!new.target
~new.target
typeof new.target
delete new.target
void new.target
```
All of which are legal in v8 and SpiderMonkey in strict and sloppy mode
* stress/new-target-syntax-errors.js:
* stress/new-target.js:
2017-08-09 Ryan Haddad <ryanhaddad@apple.com>
Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255
Unreviewed test gardening.
* stress/regress-169783.js:
* wasm/stress/oom.js:
2017-08-09 Oleksandr Skachkov <gskachkov@gmail.com>
REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334
Reviewed by Yusuke Suzuki.
Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js
* stress/async-await-syntax.js:
* stress/async-iteration-syntax.js:
2017-08-08 Yusuke Suzuki <utatane.tea@gmail.com>
Unreviewed, gardening test262 for Promise resolve / reject function length
https://bugs.webkit.org/show_bug.cgi?id=175333
* test262.yaml:
2017-08-07 Robin Morisset <rmorisset@apple.com>
GetOwnProperty of TypedArray indexed fields is wrongly configurable
https://bugs.webkit.org/show_bug.cgi?id=175307
Reviewed by Saam Barati.
* stress/typedarray-getownproperty-not-configurable.js: Added.
(assert):
(foo):
2017-08-06 Yusuke Suzuki <utatane.tea@gmail.com>
Promise resolve and reject function should have length = 1
https://bugs.webkit.org/show_bug.cgi?id=175242
Reviewed by Saam Barati.
* stress/builtin-function-length.js: Added.
(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):
2017-08-06 Oleksandr Skachkov <gskachkov@gmail.com>
[ESNext] Async iteration - Implement Async Generator - parser
https://bugs.webkit.org/show_bug.cgi?id=175210
Reviewed by Yusuke Suzuki.
* stress/async-await-syntax.js:
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
* stress/async-iteration-syntax.js: Added.
(assert):
(checkSyntax):
(checkSyntaxError):
(checkSimpleAsyncGeneratorSloppyMode):
(checkSimpleAsyncGeneratorStrictMode):
(checkNestedAsyncGenerators):
(checkSimpleAsyncGeneratorSyntaxErrorInStrictMode):
* stress/generator-class-methods-syntax.js:
2017-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
JSC test wasm/js-api/test_memory_constructor.js should be skipped on memoryLimited
https://bugs.webkit.org/show_bug.cgi?id=175150
Unreviewed test gardening.
* wasm/js-api/test_memory_constructor.js:
2017-08-02 Carlos Alberto Lopez Perez <clopez@igalia.com>
[Linux] JSTests/wasm/stress/oom.js should not run on Linux
https://bugs.webkit.org/show_bug.cgi?id=175100
Reviewed by Mark Lam.
The JSC test JSTests/wasm/stress/oom.js tries to use all the
available memory until an out of memory exception happens.
The Linux kernel is more tuned for server workloads than for GUI
responsiveness. When a process tries to use a lot of memory, Linux
will do its best to serve the request. This usually translates to
free physical RAM by writing to disk dirty pages and/or moving out
less recently used pages to swap (disk storage).
Meanwhile it does this, the system will become unresponsive and this
leads to freezes that can last even some minutes on the worst cases.
Therefore, let's skip this test on Linux as it will cause more harm
than good on the Linux bots or on the machines of Linux developers.
* wasm/stress/oom.js:
2017-08-01 Oleksandr Skachkov <gskachkov@gmail.com>
[JSC] Remove unnecessary print from stress\promise-finally.js test
https://bugs.webkit.org/show_bug.cgi?id=175015
Reviewed by Yusuke Suzuki.
* stress/promise-finally.js:
(p.finally):
(then):
2017-07-31 Yusuke Suzuki <utatane.tea@gmail.com>
Unreviewed, update test262 results for optional catch binding
* test262.yaml:
2017-07-31 Yusuke Suzuki <utatane.tea@gmail.com>
[JSC] Support optional catch binding
https://bugs.webkit.org/show_bug.cgi?id=174981
Reviewed by Saam Barati.
* stress/optional-catch-binding-syntax.js: Added.
(testSyntax):
(testSyntaxError):
(catch.catch):
* stress/optional-catch-binding.js: Added.
(shouldBe):
(throwException):
2017-07-28 Mark Lam <mark.lam@apple.com>
ObjectToStringAdaptiveStructureWatchpoint should not fire if it's dying imminently.
https://bugs.webkit.org/show_bug.cgi?id=174948
<rdar://problem/33495680>
Reviewed by Filip Pizlo.
* stress/regress-174948.js: Added.
2017-07-28 Yusuke Suzuki <utatane.tea@gmail.com>
ASSERTION FAILED: candidate->op() == PhantomCreateRest || candidate->op() == PhantomDirectArguments || candidate->op() == PhantomClonedArguments || candidate->op() == PhantomSpread || candidate->op() == PhantomNewArrayWithSpread
https://bugs.webkit.org/show_bug.cgi?id=174900
Reviewed by Saam Barati.
* stress/arguments-elimination-candidate-listings-should-respect-pseudo-terminals.js: Added.
(sideEffect):
(args):
(test):
2017-07-27 Yusuke Suzuki <utatane.tea@gmail.com>
Hoist DOM binding attribute getter prologue into JavaScriptCore taking advantage of DOMJIT / CheckSubClass
https://bugs.webkit.org/show_bug.cgi?id=171637
Reviewed by Darin Adler.
* stress/domjit-getter-complex-with-incorrect-object.js:
(i.shouldThrow):
* stress/domjit-getter-type-check.js: Copied from JSTests/stress/domjit-getter-complex-with-incorrect-object.js.
(shouldBe):
(i.shouldThrow):
2017-07-26 JF Bastien <jfbastien@apple.com>
WebAssembly: test throwing out of the start function
https://bugs.webkit.org/show_bug.cgi?id=165714
<rdar://problem/29760251>
Reviewed by Keith Miller.
* wasm/assert.js:
* wasm/function-tests/trap-from-start.js: Added.
(StartTraps):
* wasm/function-tests/trap-from-start-async.js: Added.
(async.StartTrapsAsync):
2017-07-21 Yusuke Suzuki <utatane.tea@gmail.com>
[FTL] Arguments elimination is suppressed by unreachable blocks
https://bugs.webkit.org/show_bug.cgi?id=174352
Reviewed by Filip Pizlo.
* stress/arguments-elimination-force-exit.js: Added.
(shouldBe):
(strict):
(sloppy):
* stress/arguments-elimination-throw.js: Added.
(shouldBe):
(shouldThrow):
(sloppy):
(isArguments):
2017-07-13 Mark Lam <mark.lam@apple.com>
Add some additional test cases for bug 170896.
https://bugs.webkit.org/show_bug.cgi?id=174491
Reviewed by Filip Pizlo.
* stress/regress-170896-with-contiguous-shape-profile.js: Copied from JSTests/stress/regress-170896.js.
* stress/regress-170896-with-double-shape-profile.js: Added.
(test):
* stress/regress-170896-with-int32-shape-profile.js: Added.
(test):
* stress/regress-170896.js: Removed.
2017-07-13 Saam Barati <sbarati@apple.com>
Missing exception check in JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=174455
<rdar://problem/31384608>
Reviewed by Mark Lam.
* stress/has-instance-exception-check.js: Added.
(assert):
(let.getter.Object.getOwnPropertyDescriptor.get foo):
2017-07-13 Caio Lima <ticaiolima@gmail.com>
[ESnext] Implement Object Spread
https://bugs.webkit.org/show_bug.cgi?id=167963
Reviewed by Saam Barati.
* stress/obj-rest-destructuring-order.js: Added.
(assert):
(o.get z):
(o.get a):
* stress/obj-spread-order.js: Added.
(assert):
(o.get z):
(o.get a):
* stress/object-spread.js: Added.
(let.assert):
(assert.sameValue):
(let.o.get a):
(let.obj.get c):
(cthulhu.get x):
(let.obj.set c):
(calls.o.get z):
(calls.o.get a):
(try.let.obj.get foo):
(get calls):
2017-07-12 Saam Barati <sbarati@apple.com>
GenericArguments consults the wrong state when tracking modified argument descriptors and mapped arguments
https://bugs.webkit.org/show_bug.cgi?id=174411
<rdar://problem/31696186>
Reviewed by Mark Lam.
* stress/generic-arguments-correct-delete-behavior.js: Added.
(assert):
(makeTest):
2017-07-07 Mark Lam <mark.lam@apple.com>
\n\r is not the same as \r\n.
https://bugs.webkit.org/show_bug.cgi?id=173053
Reviewed by Keith Miller.
* stress/regress-173053.js: Added.
* stress/template-literal-line-terminators.js:
2017-07-06 Saam Barati <sbarati@apple.com>
We are missing places where we invalidate the for-in context
https://bugs.webkit.org/show_bug.cgi?id=174184
Reviewed by Geoffrey Garen.
* stress/for-in-invalidate-context-weird-assignments.js: Added.
(assert):
(test):
2017-07-05 Saam Barati <sbarati@apple.com>
NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
https://bugs.webkit.org/show_bug.cgi?id=174188
<rdar://problem/30581423>
Reviewed by Mark Lam.
* stress/new-array-having-a-bad-time-double.js: Added.
(assert):
(foo):
2017-07-05 Yusuke Suzuki <utatane.tea@gmail.com>
WTF::StringImpl::copyChars segfaults when built with GCC 7
https://bugs.webkit.org/show_bug.cgi?id=173407
Reviewed by Andreas Kling.
* stress/string-repeat-copy-chars-crash.js: Added.
(shouldBe):
2017-07-03 Saam Barati <sbarati@apple.com>
Skip unshiftCountSlowCase-correct-postCapacity.js on debug builds since it takes a long time to run.
* stress/unshiftCountSlowCase-correct-postCapacity.js:
2017-07-03 Yusuke Suzuki <utatane.tea@gmail.com>
Unreviewed, annotate dont--reserve-huge-capacity-lexer.js with $memoryLimited
It requires too much memory.
* stress/dont-reserve-huge-capacity-lexer.js:
2017-06-30 Michael Saboff <msaboff@apple.com>
Skip a test on ARM64 platform since we run out of address space.
Rubber stamped by Saam Barati.
* stress/dont-reserve-huge-capacity-lexer.js:
2017-06-30 Michael Saboff <msaboff@apple.com>
RegExp's anchored with .* with \g flag can return wrong match start for strings with multiple matches
https://bugs.webkit.org/show_bug.cgi?id=174044
Reviewed by Oliver Hunt.
New regression test.
* stress/regress-174044.js: Added.
(test1):
(test2):
2017-06-30 Filip Pizlo <fpizlo@apple.com>
RegExpCachedResult::setInput should reify left and right contexts
https://bugs.webkit.org/show_bug.cgi?id=173818
Reviewed by Keith Miller.
* stress/right-left-context-invalidated-by-input.js: Added.
(test.validateContexts):
(test):
2017-06-29 Saam Barati <sbarati@apple.com>
Calculating postCapacity in unshiftCountSlowCase is wrong
https://bugs.webkit.org/show_bug.cgi?id=173992
<rdar://problem/32283199>
Reviewed by Keith Miller.
* stress/unshiftCountSlowCase-correct-postCapacity.js: Added.
(temp):
2017-06-29 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r218512.
https://bugs.webkit.org/show_bug.cgi?id=173981
"It changes the behavior of the JS API's JSEvaluateScript
which breaks TurboTax" (Requested by saamyjoon on #webkit).
Reverted changeset:
"test262: Completion values for control flow do not match the
spec"
https://bugs.webkit.org/show_bug.cgi?id=171265
http://trac.webkit.org/changeset/218512
2017-06-27 JF Bastien <jfbastien@apple.com>
WebAssembly: running out of executable memory should throw OoM
https://bugs.webkit.org/show_bug.cgi?id=171537
<rdar://problem/32963338>
Reviewed by Saam Barati.
* wasm.yaml:
* wasm/lowExecutableMemory/executable-memory-oom.js: Added.
(const.invoke):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
* wasm/lowExecutableMemory/exports-oom.js: Added.
(const.type):
(const.params):
(const.randomProgram):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
* wasm/lowExecutableMemory/imports-oom.js: Added.
(const.type):
(const.params):
(const.randomProgram):
(f.imports.push):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
2017-06-27 Caio Lima <ticaiolima@gmail.com>
[ESnext] Implement Object Rest - Implementing Object Rest Destructuring
https://bugs.webkit.org/show_bug.cgi?id=167962
Reviewed by Saam Barati.
* stress/object-rest-deconstruct.js: Added.
(let.assert):
(let.assertPropDescriptor):
(catch):
(get 3):
(foo):
(let.src.get y):
(let.src.set y):
(let.gen):
2017-06-27 Saam Barati <sbarati@apple.com>
Function constructor needs to follow the spec and validate parameters and body independently
https://bugs.webkit.org/show_bug.cgi?id=173303
<rdar://problem/32732526>
Reviewed by Keith Miller.
* ChakraCore/test/Function/FuncBodyES5.baseline-jsc:
* stress/function-constructor-semantics.js: Added.
(assert):
(hasSyntaxError):
(foo):
(async.foo):
(testError):
(testOK.toString):
(toString):
2017-06-26 Saam Barati <sbarati@apple.com>
RegExpPrototype.js builtin uses for-of iteration which is almost certainly incorrect
https://bugs.webkit.org/show_bug.cgi?id=173740
Reviewed by Mark Lam.
* stress/regexp-prototype-replace-builtin-should-not-use-for-of.js: Added.
(Array.prototype.Symbol.iterator):
2017-06-26 Saam Barati <sbarati@apple.com>
Skip a test on 32-bit platforms since we run out of address space.
Rubber stamped by Mark Lam.
* stress/dont-reserve-huge-capacity-lexer.js:
2017-06-26 Saam Barati <sbarati@apple.com>
Crash in JSC::Lexer<unsigned char>::setCode
https://bugs.webkit.org/show_bug.cgi?id=172754
Reviewed by Mark Lam.
* stress/dont-reserve-huge-capacity-lexer.js: Added.
(catch):
2017-06-24 Yusuke Suzuki <utatane.tea@gmail.com>
[JSC] Clean up Object.entries implementation
https://bugs.webkit.org/show_bug.cgi?id=173759
Reviewed by Sam Weinig.
* microbenchmarks/object-entries.js: Added.
(test):
2017-06-24 Joseph Pecoraro <pecoraro@apple.com>
Remove Reflect.enumerate
https://bugs.webkit.org/show_bug.cgi?id=173806
Reviewed by Yusuke Suzuki.
* ChakraCore.yaml:
* es6.yaml:
These tests now fail because they use Reflect.enumerate.
* test262.yaml:
This test now passes, it checked that Reflect.enumerate is undefined!
* stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js:
Convert to for..in which presented the original issue. See bug <https://webkit.org/b/149811>
* stress/reflect-enumerate.js: Removed.
Remove a test solely for Reflect.enumerate.
2017-06-22 Saam Barati <sbarati@apple.com>
ValueRep(DoubleRep(@v)) can not simply convert to @v
https://bugs.webkit.org/show_bug.cgi?id=173687
<rdar://problem/32855563>
Reviewed by Mark Lam.
* stress/dont-strength-reduce-valuerep-of-doublerep.js: Added.
(i.catch):
2017-06-22 Yusuke Suzuki <utatane.tea@gmail.com>
[JSC] Object.values should be implemented in C++
https://bugs.webkit.org/show_bug.cgi?id=173703
Reviewed by Sam Weinig.
* microbenchmarks/object-keys-map-values.js: Added.
(test):
* microbenchmarks/object-values.js: Added.
(test):
* stress/object-values-changing-properties.js: Added.
(shouldBe):
(throw.new.Error.let.source.get x):
(throw.new.Error):
(shouldBe.let.handler.get order):
(get let):
(shouldBe.let.handler.get return):
(let.handler.get order):
2017-06-21 Saam Barati <sbarati@apple.com>
eval virtual call is incorrect in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=173587
<rdar://problem/32867897>
Reviewed by Michael Saboff.
* stress/do-eval-virtual-call-correctly.js: Added.
(assert):
(f):
(i.test):
(catch):
2017-06-20 Ryan Haddad <ryanhaddad@apple.com>
Update test262 test expectations after r218581.
Unreviewed test gardening.
* test262.yaml:
2017-06-20 Oleksandr Skachkov <gskachkov@gmail.com>
Revert changes in bug#160417 about extending `null` not being a derived class
https://bugs.webkit.org/show_bug.cgi?id=169293
Reviewed by Saam Barati.
* stress/class-derived-from-null.js:
(assertThrow):
(test1):
(test2):
(test3):
(test4):
(test5):
(test6):
2017-06-13 Yusuke Suzuki <utatane.tea@gmail.com>
[DFG] More ArrayIndexOf fixups for various types
https://bugs.webkit.org/show_bug.cgi?id=173176
Reviewed by Saam Barati.
* stress/array-indexof-arraystorage.js: Added.
(shouldBe):
(indexOfInt32Other):
(indexOfInt32Cell):
(indexOfInt32Boolean):
(indexOfDoubleOther):
(indexOfDoubleCell):
(indexOfDoubleBoolean):
(indexOfInt32):
(indexOfDouble):
* stress/array-indexof-constant-folding.js: Added.
(shouldBe):
(indexOfInt32Other):
(indexOfInt32Cell):
(indexOfInt32Boolean):
(indexOfDoubleOther):
(indexOfDoubleCell):
(indexOfDoubleBoolean):
* stress/array-indexof-hole-and-other.js: Added.
(shouldBe):
(indexOf):
* stress/array-indexof-other.js: Added.
(shouldBe):
(indexOfInt32):
(indexOfDouble):
(indexOfString):
(indexOfObject):
* stress/array-indexof-symbol.js: Added.
(shouldBe):
(indexOfInt32):
(indexOfDouble):
(indexOfString):
(indexOfObject):
2017-06-19 Joseph Pecoraro <pecoraro@apple.com>
test262: Completion values for control flow do not match the spec
https://bugs.webkit.org/show_bug.cgi?id=171265
Reviewed by Saam Barati.
* stress/completion-value.js:
Condensed test for completion values in top level statements.
* stress/super-get-by-id.js:
ClassDeclaration when evaled no longer produce values. Convert
these to ClassExpressions so they produce the class value.
* ChakraCore/test/GlobalFunctions/evalreturns3.baseline-jsc:
This is a progression for currect spec behavior.
* mozilla/mozilla-tests.yaml:
This test is now outdated, so mark it as failing for that reason.
* test262.yaml:
Passing all "cptn" completion value tests.
2017-06-17 Keith Miller <keith_miller@apple.com>
ArrayBuffer constructor needs to create subclass structures before its buffer
https://bugs.webkit.org/show_bug.cgi?id=173510
Reviewed by Yusuke Suzuki.
* test262.yaml:
2017-06-17 Keith Miller <keith_miller@apple.com>
ArrayPrototype methods should use JSValue::toLength for non-Arrays.
https://bugs.webkit.org/show_bug.cgi?id=173506
Reviewed by Ryosuke Niwa.
Re-baseline tests.
* ChakraCore/test/Function/apply3.baseline-jsc:
* test262.yaml:
2017-06-16 Yusuke Suzuki <utatane.tea@gmail.com>
[JSC] Add fast path for Object.assign
https://bugs.webkit.org/show_bug.cgi?id=173416
Reviewed by Mark Lam.
* stress/object-assign-changing-properties.js: Added.
(shouldBe):
(throw.new.Error.let.source.get x):
(throw.new.Error):
(shouldBe.let.source.get x):
(shouldBe.let.target.set x):
(shouldBe.let.target.get x):
* stress/object-assign-proxy.js: Added.
(shouldBe):
(throw.new.Error.let.handler.get order):
2017-06-15 Yusuke Suzuki <utatane.tea@gmail.com>
[JSC] Implement Object.assign in C++
https://bugs.webkit.org/show_bug.cgi?id=173414
Reviewed by Saam Barati.
* stress/object-assign-string-first.js: Added.
(shouldBe):
(source.get Symbol):
(source.get 1):
(source.get cocoa):
2017-06-14 JF Bastien <jfbastien@apple.com>
WebAssembly: remove empty test files
https://bugs.webkit.org/show_bug.cgi?id=173382
Reviewed by Saam Barati.
The following files:
JSTests/wasm/function-tests/call-indirect-params.js
JSTests/wasm/function-tests/call-indirect.js
JSTests/wasm/js-api/call-indirect-results.js
Were changed to empty files in https://trac.webkit.org/changeset/209771
They were testing call_indirect with the wrong semantics, before
we implemented tables. That change implemented tables and
therefore removed the erroneous tests.
We have a few tests for call_indirect which already do the right thing:
JSTests/wasm/function-tests/context-switch.js
JSTests/wasm/function-tests/exceptions.js
JSTests/wasm/function-tests/grow-memory-2.js
JSTests/wasm/function-tests/stack-overflow.js
JSTests/wasm/function-tests/table-basic-2.js
JSTests/wasm/function-tests/table-basic.js
JSTests/wasm/js-api/call-indirect.js
JSTests/wasm/js-api/table.js
JSTests/wasm/js-api/unique-signature.js
JSTests/wasm/js-api/wrapper-function.js
I also just imported the updated spec tests which, among other
things, test call_indirect:
core/br.wast
core/br_table.wast
core/call_indirect.wast
core/func.wast
core/func_ptrs.wast
core/imports.wast
core/left-to-right.wast
core/linking.wast
core/nop.wast
core/return.wast
core/typecheck.wast
core/unreachable.wast
So I think it's OK to just delete the tests which should just have
been deleted back when tables were added.
* wasm/function-tests/call-indirect-params.js: Removed.
* wasm/function-tests/call-indirect.js: Removed.
* wasm/js-api/call-indirect-results.js: Removed.
2017-06-13 JF Bastien <jfbastien@apple.com>
WebAssembly: import updated spec tests
https://bugs.webkit.org/show_bug.cgi?id=173287
<rdar://problem/32725975>
Reviewed by Saam Barati.
Import spec tests as of 31c641cc15f2aedbec2fa45a5185f68416df578b,
with a few modifications so things work.
Fix a bunch of bugs found through this process, and punt a few tests (which I
marked as blocked by this bug).
Fixes:
Fix load / store alignment: r216908 erroneously implemented it as bit alignment
instead of byte alignment. It was also missing memory-alignment.js despite it
being in the ChangeLog, so add it too. This allows spec-test/align.wast.js to
pass.
Tables can be imported or in a section. There can be only one, but sections can
be empty. An Elements section can exist if there's no Table, as long as it is
also empty.
Memories can be imported or in a section. There can be only one, but sections
can be empty. A Data section can exist if there's no Memory, as long as it is
also empty.
Prototypes: stringify without .prototype. in the string.
WebAssembly.Table.prototype.grow was plain wrong: it takes a delta parameter,
not a final size, and throws a RangeError on failure, not a TypeError.
Fix compile / instantiate so the reject the promise if given an argument of the
wrong type (instead of failing instantly).
Fix async on neuter test.
Element section shouldn't affect any Table if any of the elements are out of
bounds. We need to process it in two passes.
Segment section shouldn't affect any Data if any of the segments are out of
bounds. We need to process it in two passes.
Empty data segments are valid, but only when there is no memory. Their index
still gets validated, and has to be zero.
Punts:
Error messages with context, the test seems overly restrictive but this is
minor.
compile/instantiate/validate property descriptors.
UTF-8 bugs.
Temporarily disable NaN tests. We need to go back and implement the following
semantics: https://github.com/WebAssembly/spec/pull/414 This doesn't matter as
much as getting all the other tests passing.
Worth noting for NaNs: f64.no_fold_mul_one (also a NaN test) as well as
no_fold_promote_demote (an interesting corner case which we get wrong). mul by
one is (assert_return (invoke \"f64.no_fold_mul_one\" (i64.const
0x7ff4000000000000)) (i64.const 0x7ff8000000000000)) which means converting sNaN
to qNaN, and promote/demote is (assert_return (invoke \"no_fold_promote_demote\"
(i32.const 0x7fa00000)) (i32.const 0x7fc00000)) which is the same. I'm not sure
why they're not allowed.
* wasm.yaml:
* wasm/function-tests/i32-load8-s.js:
* wasm/function-tests/memory-access-past-4gib.js:
(const.op.of.WASM.opcodes):
* wasm/function-tests/memory-alignment.js: Added.
(const.op.of.WASM.opcodes):
* wasm/function-tests/memory-section-and-import.js:
* wasm/js-api/Module-compile.js:
(async.testPromiseAPI):
* wasm/js-api/dont-mmap-zero-byte-memory.js:
(testMems):
* wasm/js-api/element.js:
(assert.throws.new.WebAssembly.Module.builder.WebAssembly):