https://bugs.webkit.org/show_bug.cgi?id=242279

Reviewed by Philippe Normand.

* Tools/buildstream/elements/sdk/mold.bst: Bump to version 1.3.1

Canonical link: https://commits.webkit.org/252097@main

…ttribute don't render when characters in that range are present

https://bugs.webkit.org/show_bug.cgi?id=241831
<rdar://95646820>

Reviewed by Alan Bujtas.

When we fall off the end of the font fallback list, we create a "system fallback" font. It's possible for
this font to be a web font (see w3c/csswg-drafts#7449 for discussion about this).
If it is a web font, we need to preserve the CreationData of the font so it can be transferred across IPC.

Test: fast/text/font-face-fall-off-end.html

* LayoutTests/fast/text/font-face-fall-off-end-expected.html:
* LayoutTests/fast/text/font-face-fall-off-end.html:
* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):

Canonical link: https://commits.webkit.org/252096@main

https://bugs.webkit.org/show_bug.cgi?id=242161

Reviewed by Antti Koivisto.

Let's just use the flexGrow() value as the base for distribution.

* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):

Canonical link: https://commits.webkit.org/252095@main

…istribution

https://bugs.webkit.org/show_bug.cgi?id=242131

Reviewed by Antti Koivisto.

This patch resolves the logical width of a flex item upfront when flex-basis is applicable. It fixes cases when there's no space to distribute and the final logical width is based on the flex-basis value.
<div style="display: flex; width: 100px;">
  <div style="width: 1px; flex-basis: 50px;"></div>
  <div style="width: 2px; flex-basis: 50px;"></div>
</div>

* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):

Canonical link: https://commits.webkit.org/252094@main

…es and Computed panels

https://bugs.webkit.org/show_bug.cgi?id=242186

Reviewed by Devin Rousso and Patrick Angle.

The visibility of the filter bar was guarded on the truthiness of `this._filterBar`,
a check that occured in `_showPanel()` before the filter bar was created in `initialLayout()`.
This resulted in a filter bar that was eventually created but remained hidden.

This patch inlines the contents of `WI.GeneralStyleDetailsSidebarPanel._showPanel()`
into `WI.GeneralStyleDetailsSidebarPanel.initialLayout()` ensuring the filter bar is
always visible if created.

* Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
 (WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout):
 (WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel): Deleted.

Canonical link: https://commits.webkit.org/252093@main

…acters()

https://bugs.webkit.org/show_bug.cgi?id=242284

Reviewed by Cameron McCormack.

All the implementations immediately dereference the pointer, so it should be
a reference instead.

* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::systemFallbackFontForCharacter const):
* Source/WebCore/platform/graphics/FontCache.h:
* Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::fontForCombiningCharacterSequence const):
* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* Source/WebCore/platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters):

Canonical link: https://commits.webkit.org/252092@main

https://bugs.webkit.org/show_bug.cgi?id=242287

Reviewed by Tim Nguyen.

We need to ensure that the promise always remains alive when in use.
Adding a RefPtr guarantees that it will not be garbage collected.

* Source/WebCore/crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::unwrapKey):

Canonical link: https://commits.webkit.org/252091@main

…ypes

https://bugs.webkit.org/show_bug.cgi?id=242149

Reviewed by Chris Dumez.

This is a legit use case (some of our clients do this) that is not covered by existing tests.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

Canonical link: https://commits.webkit.org/252090@main

https://bugs.webkit.org/show_bug.cgi?id=242265

Reviewed by Darin Adler.

GraphicsLayer::supportsBackgroundColorContent returns true for all
ports. Removed it.

* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::supportsBackgroundColorContent): Deleted.
* Source/WebCore/platform/graphics/GraphicsLayer.h:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::supportsBackgroundColorContent): Deleted.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::supportsDirectlyCompositedBoxDecorations):

Canonical link: https://commits.webkit.org/252089@main

https://bugs.webkit.org/show_bug.cgi?id=242202

Reviewed by Eric Carlson.

Currently the logic for falling back to a different media player in the
occasion that the current media player is unable to load the media resource
assumes that there exists a "next best" media engine (which means another
media engine supports the current MIME type).

This does not consider the case when none of the registered media engines
know if they can support the content based on the MIME type. In such a scenario,
the next registered media engine should attempt to load the content.

A HashSet is used to keep track of the attempted media engines to prevent
an infinite cycle of reloads.

* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::bestMediaEngineForSupportParameters):
(WebCore::MediaPlayer::nextMediaEngine):
(WebCore::MediaPlayer::nextBestMediaEngine):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
* Source/WebCore/platform/graphics/MediaPlayer.h:

Canonical link: https://commits.webkit.org/252088@main

https://bugs.webkit.org/show_bug.cgi?id=242112

Reviewed by Antti Koivisto.

While non-stretching (flex-grow: 0) flex items don't participate in available space distribution, they don't necessarily end up with their logical width as used value (final width) when flex-basis is taken into account.
This patch ensures that we produce valid used width values even for non-stretching flex items.

Canonical link: https://commits.webkit.org/252087@main

https://bugs.webkit.org/show_bug.cgi?id=242282
rdar://94649571

Reviewed by Mark Lam.

This patch fixes the following issues.

1. JSDOMGuardedObject should emit write-barrier after storing a reference to JSDOMGlobalObject.
2. Regardless of m_guarded status, we should unregister itself from JSDOMGlobalObject if JSDOMGlobalObject
   is live since we register it in the constructor.

* Source/WebCore/bindings/js/JSDOMGuardedObject.cpp:
(WebCore::DOMGuardedObject::DOMGuardedObject):
(WebCore::DOMGuardedObject::clear):
(WebCore::DOMGuardedObject::removeFromGlobalObject):

Canonical link: https://commits.webkit.org/252086@main

https://bugs.webkit.org/show_bug.cgi?id=242262
<rdar://81438938>

Reviewed by Eric Carlson.

LibWebRTCAudioModule has a Timer data member which gets constructed on the main thread,
gets started / stopped on the main thread and fires on the main thread. However, the
LibWebRTCAudioModule can get destroyed on a non-main thread, which would also destroy
the Timer on that thread. This wasn't safe and would result in crashes.

To address the issue, I now do a callOnMainThreadAndWait() in the LibWebRTCAudioModule
destructor and make sure to destroy the timer on the main thread. The "AndWait" part
is necessary since the timer may fire on the main thread during the execution on the
LibWebRTCAudioModule destructor on the background thread.

* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::LibWebRTCAudioModule):
(WebCore::LibWebRTCAudioModule::~LibWebRTCAudioModule):
(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::StopPlayout):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:

Canonical link: https://commits.webkit.org/252085@main

https://bugs.webkit.org/show_bug.cgi?id=242283
<rdar://96326646>

Unreviewed build fix

* Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:

Canonical link: https://commits.webkit.org/252084@main

rdar://86340301

Reviewed by Alexey Proskuryakov.

webkitdirs.pm computes an ARCHS build setting based on the --sdk flag
given to it. Teach Make to pass its SDKROOT override when calling
XcodeOptionString().

This should issues when an Xcode toolchain supports building for arm64e,
but the selected SDK does not, causing a linker failure like:

    Undefined symbols for architecture arm64e:
      "___muloti4", referenced from:
          WTF::ArithmeticOperations<__int128, __int128, __int128, true, true>::multiply(__int128, __int128, __int128&) in UnifiedSource106.o

* Makefile.shared:

Canonical link: https://commits.webkit.org/252083@main

https://bugs.webkit.org/show_bug.cgi?id=242258

Reviewed by Jonathan Bedard.

Refactor XcodeOptions to look for feature flags (--<feature> and
--no-<feature>) in argv and pass the corresponding build settings to
Xcode.

With this change,

    build-webkit --debug --<feature>

and

    make debug BUILD_WEBKIT_OPTIONS=--<feature>

provide the same feature settings for Xcode-based platforms.

This doesn't change the code path build-webkit uses for feature flags,
because it handles their parsing in its top-level Getopt::GetOptions
call.

* Tools/Scripts/webkitdirs.pm:
(XcodeOptions):
* Tools/Scripts/webkitperl/FeatureList.pm:
(getFeatureOptionList): Lazily call prohibitUnknownPort when the feature
list is queried, instead of when it's loaded, to avoid a circular
dependency preventing this file from being imported by webkitdirs.

Canonical link: https://commits.webkit.org/252082@main

https://bugs.webkit.org/show_bug.cgi?id=242272

Reviewed by Alex Christensen.

When a curl connection is using HTTP/3 report it to NetworkLoadMetrics as "h3". Ensures that the
protocol in Web Inspector's Network tab is correct.

* Source/WebCore/platform/network/curl/CurlContext.cpp:

Canonical link: https://commits.webkit.org/252081@main

https://bugs.webkit.org/show_bug.cgi?id=224063
<rdar://76114559>

Unreviewed follow-up fix.

* Tools/WebKitBot/src/WebKitBot.mjs: Do not convert all revisions to integers,
support variety of hash lengths.

Canonical link: https://commits.webkit.org/252080@main

… is randomly failing

https://bugs.webkit.org/show_bug.cgi?id=242231

Reviewed by Adrian Perez de Castro.

This test had two problems. jsTestIsAsync wasn't defined in the top
level. js-test-post.js wasn't included even though js-test-pre.js was
used.

Use js-test.js intead of js-test-pre.js. It doesn't need
js-test-post.js.

* LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:
* LayoutTests/svg/animations/animation-leak-list-property-instances.html:

Canonical link: https://commits.webkit.org/252079@main

https://bugs.webkit.org/show_bug.cgi?id=241824
<rdar://95642497>

Reviewed by Yusuke Suzuki and Alexey Proskuryakov.

* Tools/WebKitBot/src/WebKitBot.mjs: Use pure-git tools to update checkout.

Canonical link: https://commits.webkit.org/252078@main

https://bugs.webkit.org/show_bug.cgi?id=242276
rdar://96053526

Reviewed by Mark Lam.

This patch cleans up ControlEntry related code to make things simpler for the new extensions.

* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::ControlType::isCatch):
(JSC::Wasm::LLIntGenerator::ControlType::isCatchAll):
(JSC::Wasm::LLIntGenerator::ControlType::targetLabelForBranch const):
(JSC::Wasm::LLIntGenerator::ControlType::branchTargetArity const):
(JSC::Wasm::LLIntGenerator::ControlType::branchTargetType const):
(JSC::Wasm::LLIntGenerator::ControlType::dump const):
(JSC::Wasm::LLIntGenerator::ControlType::convertToCatch):
(JSC::Wasm::LLIntGenerator::addElse):
(JSC::Wasm::LLIntGenerator::addCatchToUnreachable):
(JSC::Wasm::LLIntGenerator::addCatchAllToUnreachable):
(JSC::Wasm::LLIntGenerator::addRethrow):
(JSC::Wasm::LLIntGenerator::addEndToUnreachable):
(JSC::Wasm::LLIntGenerator::dump):
(JSC::Wasm::LLIntGenerator::ControlType::createCatch): Deleted.

Canonical link: https://commits.webkit.org/252077@main

…ing.html is a flaky failure

https://bugs.webkit.org/show_bug.cgi?id=242273
<rdar://96317337>

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/252076@main

https://bugs.webkit.org/show_bug.cgi?id=224063
<rdar://76114559>

Reviewed by Stephanie Lewis.

* Tools/Scripts/webkitpy/common/checkout/checkout.py:
(_changelog_data_for_revision): Support any commit argument.
* Tools/Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.commit_info_for_revision): Support r prefixed strings.
* Tools/Scripts/webkitpy/common/checkout/scm/git.py:
(Git.changed_files_for_revision): Use git_commit_from_string.
(Git.git_commit_from_string): Renamed from git_commit_from_svn_revision.
(Git.contents_at_revision): Use git_commit_from_string.
(Git.diff_for_revision): Ditto
(Git.committer_email_for_revision): Ditto.
(Git.apply_reverse_diff): Ditto.
(Git.git_commit_from_svn_revision): Rename git_commit_from_string.
* Tools/Scripts/webkitpy/common/config/urls.py:
(view_revision_url): Support any commit argument.
* Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py:
(Attachment): Caller should prefix r, if appropriate.
* Tools/Scripts/webkitpy/tool/commands/download.py:
(AbstractRevertPrepCommand._prepare_state): Handle multiple types of commit arguments.
(CreateRevert._prepare_state): Remove r prefix.
* Tools/Scripts/webkitpy/tool/commands/download_unittest.py:
(AbstractRevertPrepCommandTest.test_prepare_state):
* Tools/Scripts/webkitpy/tool/steps/reopenbugafterrevert.py:
(ReopenBugAfterRevert.run): Remove r prefix.
* Tools/WebKitBot/src/WebKitBot.mjs: Allow hashes and identifiers in webkitbot.

Canonical link: https://commits.webkit.org/252075@main

https://bugs.webkit.org/show_bug.cgi?id=242222

Reviewed by Antoine Quint and Devin Rousso.

Add ENABLE(FULLSCREEN_DISMISSAL_GESTURES), which is enabled
on PLATFORM(IOS_FAMILY).

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen]):

Canonical link: https://commits.webkit.org/252074@main

…ecoding.html is a flaky failure

https://bugs.webkit.org/show_bug.cgi?id=242270
<rdar://96316372>

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/252073@main

https://bugs.webkit.org/show_bug.cgi?id=242271

Unreviewed build fix.

* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::toWindowSceneGeometryPreferences):

Canonical link: https://commits.webkit.org/252072@main

https://bugs.webkit.org/show_bug.cgi?id=241964

Reviewed by Alex Christensen and Brent Fulgham.

Implement initial stubs for Compression Streams API.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/compression/CompressionStream.cpp: Added.
(WebCore::CompressionStream::createStreams):
(WebCore::CompressionStream::readable):
(WebCore::CompressionStream::writable):
* Source/WebCore/Modules/compression/CompressionStream.h: Added.
(WebCore::CompressionStream::~CompressionStream):
(WebCore::CompressionStream::create):
(WebCore::CompressionStream::getCompressionFormat):
(WebCore::CompressionStream::CompressionStream):
* Source/WebCore/Modules/compression/CompressionStream.idl: Added.
* Source/WebCore/Modules/compression/DecompressionStream.cpp: Added.
(WebCore::DecompressionStream::createStreams):
(WebCore::DecompressionStream::readable):
(WebCore::DecompressionStream::writable):
* Source/WebCore/Modules/compression/DecompressionStream.h: Added.
(WebCore::DecompressionStream::~DecompressionStream):
(WebCore::DecompressionStream::create):
(WebCore::DecompressionStream::getCompressionFormat):
(WebCore::DecompressionStream::DecompressionStream):
* Source/WebCore/Modules/compression/DecompressionStream.idl: Added.
* Source/WebCore/Modules/compression/Formats.h: Added.
* Source/WebCore/Modules/streams/GenericTransformStream.idl: Added.
* Source/WebCore/Modules/websockets/WebSocket.cpp:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/EventTargetFactory.in:
* Source/WebCore/features.json:

Canonical link: https://commits.webkit.org/252071@main

…hildClippingMaskLayer

https://bugs.webkit.org/show_bug.cgi?id=242209

Reviewed by Darin Adler.

After 252014@main (bug#242097), GraphicsLayer::supportsRoundedClip
returns true for all ports. We can remove it. And,
m_childClippingMaskLayer was created only if supportsRoundedClip
returns false. We can remove it together.

* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::supportsRoundedClip): Deleted.
* Source/WebCore/platform/graphics/GraphicsLayer.h:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::supportsRoundedClip): Deleted.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updatePaintingPhases):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate const):
(WebCore::RenderLayerBacking::updateChildClippingStrategy): Deleted.
* Source/WebCore/rendering/RenderLayerBacking.h:

Canonical link: https://commits.webkit.org/252070@main

https://bugs.webkit.org/show_bug.cgi?id=240261

Reviewed by Jonathan Bedard.

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults._format_values):

Canonical link: https://commits.webkit.org/252069@main

https://bugs.webkit.org/show_bug.cgi?id=242255

Reviewed by Jonathan Bedard.

Add Rupin Mittal to contributors.json.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/252068@main

https://bugs.webkit.org/show_bug.cgi?id=242188

Reviewed by Darin Adler.

Make getSpace return an optional LayoutUnit.

* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::getSpace):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry const):

Canonical link: https://commits.webkit.org/252067@main

https://bugs.webkit.org/show_bug.cgi?id=242152
<rdar://90663179>

Reviewed by Geoffrey Garen.

When the WebContent process is requesting icon rendering in the UI process, create the bitmap with
the 'iconSize' constant. We use the same constant when generating bitmaps for the thumbnail icons
in the UI process.

* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::iconForAttachment):

Canonical link: https://commits.webkit.org/252066@main

https://bugs.webkit.org/show_bug.cgi?id=242205

Reviewed by Geoffrey Garen.

The function removeCollationFunction is not used anywhere.

* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::removeCollationFunction): Deleted.
* Source/WebCore/platform/sql/SQLiteDatabase.h:

Canonical link: https://commits.webkit.org/252065@main

https://bugs.webkit.org/show_bug.cgi?id=242259
<rdar://96029757>

Reviewed by Chris Dumez.

Fix memory leak after calling AudioComponentFetchServerRegistrations.

* Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm:
(WebKit::AuxiliaryProcessProxy::fetchAudioComponentServerRegistrations):

Canonical link: https://commits.webkit.org/252064@main

https://bugs.webkit.org/show_bug.cgi?id=242257
<rdar://71160678>

Reviewed by Sihui Liu.

We have evidence from crashes in the wild that objectStoreInfo can be null here
so add a null check for it.

* Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):

Canonical link: https://commits.webkit.org/252063@main