Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fix when SERVICE_WORKER is disabled #20566

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Build fix when SERVICE_WORKER is disabled #20566

merged 1 commit into from
Nov 18, 2023

Conversation

tKnmori
Copy link
Contributor

@tKnmori tKnmori commented Nov 15, 2023 •
edited by webkit-early-warning-system
Loading

ed1571f

Build fix when SERVICE_WORKER is disabled
https://bugs.webkit.org/show_bug.cgi?id=264902

Reviewed by Don Olmstead.

When SERVICE_WORKER is dsabled, building webkit fails.
Functions below in GeneratedSerializers.cpp should be disabled when SERVICE_WORKER is off.

isValidEnum<WebCore::BackgroundFetchFailureReason, void>
isValidEnum<WebCore::BackgroundFetchResult, void>

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270920@main

1ad9174

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@donny-dont donny-dont added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Nov 16, 2023
@donny-dont donny-dont self-assigned this Nov 17, 2023
@donny-dont donny-dont added the Service Workers Component for Service Workers bugs. label Nov 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 17, 2023 •
edited
Loading

EWS run on current version of this PR (hash 1ad9174)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash ddbcb66)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
⏳ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🧪 services ⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
⏳ 🛠 watch ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Nov 18, 2023
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #3641.

@tKnmori @donny-dont
Build fix when SERVICE_WORKER is disabled
ed1571f 
https://bugs.webkit.org/show_bug.cgi?id=264902

Reviewed by Don Olmstead.

When SERVICE_WORKER is dsabled, building webkit fails.
Functions below in GeneratedSerializers.cpp should be disabled when SERVICE_WORKER is off.

isValidEnum<WebCore::BackgroundFetchFailureReason, void>
isValidEnum<WebCore::BackgroundFetchResult, void>

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270920@main
@webkit-commit-queue
Copy link
Collaborator

Committed 270920@main (ed1571f): https://commits.webkit.org/270920@main

Reviewed commits have been landed. Closing PR #20566 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ed1571f into WebKit:main Nov 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donny-dont donny-dont donny-dont approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek

@foopoiuyt foopoiuyt Awaiting requested review from foopoiuyt

@rkirsling rkirsling Awaiting requested review from rkirsling

Assignees

@donny-dont donny-dont

Labels
Service Workers Component for Service Workers bugs.
Projects
None yet
Milestone
No milestone
5 participants
@tKnmori @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @donny-dont