Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension cropping? #24

Open
Anonanon opened this issue Apr 9, 2014 · 9 comments
Open

Dimension cropping? #24

Anonanon opened this issue Apr 9, 2014 · 9 comments

Comments

@Anonanon
Copy link

Anonanon commented Apr 9, 2014

I know you want this program to be as simple as possible, but I would recommend an option to set offsets for top, left, right, bottom to crop out. There are a lot of WebMs out there that could use a cropping feature to get rid of letterboxing. For example, all but one of Diablo III's cinematics have letterboxing baked in for some reason.

Of course the terminology here clashes with time cropping so I'd suggest renaming time cropping to "Start trim" and "End trim". Dimensions would become "Top crop" etc. measured in pixels.

Thanks for your continued updates to this program.

@Teapsalm
Copy link

Teapsalm commented Apr 9, 2014

This would be a good feature for reaction WebMs.

@WebMBro
Copy link
Owner

WebMBro commented Apr 9, 2014

I'll see what I can do. I'll be a bit busy with other stuff tomorrow though, so I'll only be able to work on this in the weekend.

@WebMBro
Copy link
Owner

WebMBro commented Apr 9, 2014

I might, in fact, try to make a graphical representation of the cropping area to make it easy to use. This would require the user to fill in both the width and the height field of the resize option, though.

@rmmh
Copy link
Contributor

rmmh commented Apr 9, 2014

ffmpeg has a -vf cropdetect filter that find black bars and outputs crop parameters. An 'autocrop' checkbox would fit better with the 'webm for retards' theme.

@nixxquality
Copy link
Contributor

I agree with rmmh. Keeping it simple is a good idea.
If you need more control than that, you can use the avisynth support present in ffmpeg.

@Anonanon
Copy link
Author

Anonanon commented Apr 9, 2014

Auto crop is good too

@WebMBro
Copy link
Owner

WebMBro commented Apr 12, 2014

I've been working on this a bit, the gui looks like this so far, any complaints?

@WebMBro
Copy link
Owner

WebMBro commented Apr 12, 2014

Okay, try the newest release, it should be sort of working now.

@omgorf
Copy link

omgorf commented Apr 12, 2014

It's good for cropping a section out while keeping the original size of what you are cropping out but say you want to crop an area and scale that down. Would there be a way to put the scale after the crop and maybe even calculate a corrected value when using the cropping feature.

For example I want to crop a section out of a 720p video, at full resolution this is 606x720 but I want to resize this down to 400:475. Now when I select the region of 606x720 I'll get -filter:v crop="606:720:70:0" which is great but as it's just a face being so large doesn't suit it so good so when you select the 606x720 area with the crop selector you could instead use -vf crop=606:720:70:0,scale=606:720 and fill in 606x720 on the resolution field. further changing of the resolution field will now also affect the scale after the crop and allow the use of -1 for keeping aspect ratio. So If I want to crop that section and then resize it I could use vf crop=606:720:70:0,scale=400:-1 Where I changed the main resolution field to 400 and -1. Maybe also only add the scale after the crop if the resolution is changed but I'm not sure if you'd be able to easily detect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants