Type definitions are buggy

[iacore]

❯ cat node_modules/uhtml/./types/dom/index.d.ts
import Document from './document.js';
import DOMParser from './dom-parser.js';
export { Document, DOMParser };

./document.js does not even exist. It should be ./document.d.ts afaik.

uhtml/init and uhtml/dom have this problem. Maybe they all have this problem.

[WebReflection]

it's tsc generating those though ... https://github.com/WebReflection/uhtml/blob/main/package.json#L17 ... 🤔

[iacore]

I removed all "types":.... lines from package.json and the types immediately worked in VSCode.

JSDoc is better. Typescript LSP recognize that.

• Ctrl+Click jump to source code, not .d.ts
• 1 less build step

For more details, see Why Svelte did TS->JSDOC.

[iacore]

I was using uhtml/init and uhtml/dom in my project, and the types was buggy. I'll fix it.

I tried. uhtml/init is generated somehow. The following code erased the type of exports.

  exports.Hole = Hole;
  exports.attr = attr;
  exports.html = html;
  exports.htmlFor = htmlFor;
  exports.render = keyed$1;
  exports.svg = svg;
  exports.svgFor = svgFor;

  return exports;

changing the code snippet to

  return {
    Hole : Hole,
    attr : attr,
    html : html,
    htmlFor : htmlFor,
    render : keyed$1,
    svg : svg,
    svgFor : svgFor,
  }

has fixed the problem for TypeScript LSP.

I think keeping only uhtml/init is the way to go. uhtml/keyed can be derived from that.