fix(add default npm registry as an explicit parameter to npm publish …

…command.):
webiny · May 28, 2018 · 9f52461 · 9f52461
1 parent 963fc4f
commit 9f52461
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/plugins/npm/publish.js b/src/plugins/npm/publish.js
@@ -3,7 +3,7 @@ import path from "path";
 import fs from "fs-extra";
 
 export default (config = {}) => {
-    const { registry, tag } = config;
+    const { registry = "https://registry.npmjs.org", tag } = config;
 
     return async ({ packages, logger, config }, next) => {
         for (let i = 0; i < packages.length; i++) {
@@ -20,7 +20,7 @@ export default (config = {}) => {
             const command = [
                 `npm publish`,
                 tag ? `--tag ${tag}` : null,
-                registry ? `--registry ${registry}` : null,
+                `--registry ${registry}`,
                 pkg.location
             ]
                 .filter(v => v)

diff --git a/tests/npmPublish.test.js b/tests/npmPublish.test.js
@@ -171,6 +171,9 @@ describe("npmPublish plugin test", function() {
         const release = compose([npmPublishFactory()]);
         await release(params);
 
-        expect(logger.log.args[1]).to.deep.equal(["DRY: %s", "npm publish " + pkg.location]);
+        expect(logger.log.args[1]).to.deep.equal([
+            "DRY: %s",
+            "npm publish --registry https://registry.npmjs.org " + pkg.location
+        ]);
     });
 });