Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Mac wk1 ] Many recently imported mixed-content WPT tests are failing on Mac wk1 #3825

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[ Mac wk1 ] Many recently imported mixed-content WPT tests are failing on Mac wk1 #3825

merged 1 commit into from
Aug 31, 2022

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Aug 30, 2022 •
edited by webkit-early-warning-system

102b793

[ Mac wk1 ] Many recently imported mixed-content WPT tests are failing on Mac wk1
https://bugs.webkit.org/show_bug.cgi?id=243733
<rdar://problem/98389628>

Reviewed by John Wilander.

* LayoutTests/platform/mac-wk1/TestExpectations:

These tests were failing because WebKitLegacy does not support Shared Workers or Beacon,
but these tests required their support. I've skipped the relevant test cases, and
re-allowed the passing tests.

Canonical link: https://commits.webkit.org/253997@main

45c4e52

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

45c4e52

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

johnwilander
johnwilander approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@johnwilander johnwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@brentfulgham brentfulgham added this to the merge-queue milestone Aug 31, 2022
@brentfulgham brentfulgham added the merge-queue Applied to send a pull request to merge-queue label Aug 31, 2022
@brentfulgham
[ Mac wk1 ] Many recently imported mixed-content WPT tests are failin…
102b793 
…g on Mac wk1

https://bugs.webkit.org/show_bug.cgi?id=243733
<rdar://problem/98389628>

Reviewed by John Wilander.

* LayoutTests/platform/mac-wk1/TestExpectations:

These tests were failing because WebKitLegacy does not support Shared Workers or Beacon,
but these tests required their support. I've skipped the relevant test cases, and
re-allowed the passing tests.

Canonical link: https://commits.webkit.org/253997@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Skip-shared-worker-tests-in-webkit-legacy branch from 45c4e52 to 102b793 Compare August 31, 2022 18:02
@webkit-commit-queue
Copy link
Collaborator

Committed 253997@main (102b793): https://commits.webkit.org/253997@main

Reviewed commits have been landed. Closing PR #3825 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 102b793 into WebKit:main Aug 31, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 31, 2022
@nt1m nt1m removed this from the merge-queue milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwilander johnwilander johnwilander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@brentfulgham @webkit-early-warning-system @webkit-commit-queue @johnwilander @nt1m