-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the unnecessary HDRMediaCapabilitiesEnabled feature flag #6900
Remove the unnecessary HDRMediaCapabilitiesEnabled feature flag #6900
Conversation
EWS run on previous version of this PR (hash 7540165) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
7540165
to
a4ba1dc
Compare
I am unable to reproduce the crash in Mac-AS-debug-wk2 on my M1 Pro machine. I've run the directory in a loop a few dozen times (in debug build), and a set of image tests in a loop 100's of times without seeing a crash. Since the bot does not capture a crash trace, I'm going to proceed with landing and watch the bots. |
https://bugs.webkit.org/show_bug.cgi?id=248436 <rdar://problem/102738537> Reviewed by Eric Carlson. Modern WebKit always enables HDRMediaCapabilitiesEnabled, and we no longer need to toggle this option for A/B testing. We should remove it to reduce the cluttered set of experimental features. * LayoutTests/fast/media/mq-highdynamicrange-live-update.html: Remove call to set the removed enablement flag. No change in behavior since the flag was always turned on, and the feature is now always enabled. * LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr-expected.txt: Ditto. * LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr.html: Ditto. * LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr-expected.txt: Ditto. * LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html: Ditto. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/Modules/mediacapabilities/VideoConfiguration.idl: * Source/WebCore/css/LegacyMediaQueryEvaluator.cpp: (WebCore::dynamicRangeEvaluate): * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::dynamicRange): Canonical link: https://commits.webkit.org/257200@main
a4ba1dc
to
49dfaed
Compare
Committed 257200@main (49dfaed): https://commits.webkit.org/257200@main Reviewed commits have been landed. Closing PR #6900 and removing active labels. |
49dfaed
a4ba1dc
π§ͺ api-gtkπ§ͺ mac-wk1