Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary HDRMediaCapabilitiesEnabled feature flag #6900

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Nov 29, 2022

49dfaed

Remove the unnecessary HDRMediaCapabilitiesEnabled feature flag
https://bugs.webkit.org/show_bug.cgi?id=248436
<rdar://problem/102738537>

Reviewed by Eric Carlson.

Modern WebKit always enables HDRMediaCapabilitiesEnabled, and we no longer need
to toggle this option for A/B testing. We should remove it to reduce the cluttered
set of experimental features.

* LayoutTests/fast/media/mq-highdynamicrange-live-update.html: Remove call to set the
removed enablement flag. No change in behavior since the flag was always turned on,
and the feature is now always enabled.
* LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr-expected.txt: Ditto.
* LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr.html: Ditto.
* LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr-expected.txt: Ditto.
* LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html: Ditto.
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/Modules/mediacapabilities/VideoConfiguration.idl:
* Source/WebCore/css/LegacyMediaQueryEvaluator.cpp:
(WebCore::dynamicRangeEvaluate):
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::dynamicRange):

Canonical link: https://commits.webkit.org/257200@main

a4ba1dc

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk πŸ’₯ πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv   πŸ§ͺ mac-wk1 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch ❌ πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-mips-tests

Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022
@brentfulgham brentfulgham removed the merging-blocked Applied to prevent a change from being merged label Nov 29, 2022
@brentfulgham brentfulgham force-pushed the eng/Remove-the-unnecessary-HDRMediaCapabilitiesEnabled-feature-flag branch from 7540165 to a4ba1dc Compare November 29, 2022 17:49
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 30, 2022
@brentfulgham brentfulgham added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 30, 2022
@brentfulgham
Copy link
Contributor Author

I am unable to reproduce the crash in Mac-AS-debug-wk2 on my M1 Pro machine. I've run the directory in a loop a few dozen times (in debug build), and a set of image tests in a loop 100's of times without seeing a crash.

Since the bot does not capture a crash trace, I'm going to proceed with landing and watch the bots.

https://bugs.webkit.org/show_bug.cgi?id=248436
<rdar://problem/102738537>

Reviewed by Eric Carlson.

Modern WebKit always enables HDRMediaCapabilitiesEnabled, and we no longer need
to toggle this option for A/B testing. We should remove it to reduce the cluttered
set of experimental features.

* LayoutTests/fast/media/mq-highdynamicrange-live-update.html: Remove call to set the
removed enablement flag. No change in behavior since the flag was always turned on,
and the feature is now always enabled.
* LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr-expected.txt: Ditto.
* LayoutTests/media/mediacapabilities/mock-decodingInfo-hdr.html: Ditto.
* LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr-expected.txt: Ditto.
* LayoutTests/platform/mac/media/mediacapabilities/hevc-decodingInfo-hdr.html: Ditto.
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/Modules/mediacapabilities/VideoConfiguration.idl:
* Source/WebCore/css/LegacyMediaQueryEvaluator.cpp:
(WebCore::dynamicRangeEvaluate):
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::dynamicRange):

Canonical link: https://commits.webkit.org/257200@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-the-unnecessary-HDRMediaCapabilitiesEnabled-feature-flag branch from a4ba1dc to 49dfaed Compare November 30, 2022 22:48
@webkit-early-warning-system webkit-early-warning-system merged commit 49dfaed into WebKit:main Nov 30, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257200@main (49dfaed): https://commits.webkit.org/257200@main

Reviewed commits have been landed. Closing PR #6900 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants