Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Use finer-grained media services when available #7397

Merged
merged 1 commit into from Dec 10, 2022
Merged

[iOS] Use finer-grained media services when available #7397

merged 1 commit into from Dec 10, 2022

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Dec 9, 2022 •
edited by webkit-early-warning-system

6cbeaff

[iOS] Use finer-grained media services when available
https://bugs.webkit.org/show_bug.cgi?id=249033
<rdar://100435873>

Reviewed by Per Arne Vollan.

Use more specific mach services for media features on platforms that support them.
This will allow us to narrow the scope to only those endpoints required for
web-related media tasks.

No change in behavior.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/257653@main

cfd16b9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash cfd16b9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

pvollan
pvollan reviewed Dec 9, 2022
View reviewed changes
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in
"com.apple.coremedia.mediaplaybackd.formatreader.xpc"
"com.apple.coremedia.mediaplaybackd.player.xpc"
"com.apple.coremedia.mediaplaybackd.remaker.xpc"
"com.apple.coremedia.mediaplaybackd.samplebufferaudiorenderer.xpc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other services we can remove access to when mediaaybackd is present? I may look like there are old counterparts to some of these new services?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can add telemetry to the old services if HAVE_MEDIAPLAYBACKD = 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvollan: Indeed, we should consider that in the future, but for now the relevant people working on this finer-grained XPC layer say they do not intend for us to remove the old items yet (though this will hopefully happen soon).

pvollan
pvollan approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@brentfulgham brentfulgham added the merge-queue Applied to send a pull request to merge-queue label Dec 9, 2022
@brentfulgham
[iOS] Use finer-grained media services when available
6cbeaff 
https://bugs.webkit.org/show_bug.cgi?id=249033
<rdar://100435873>

Reviewed by Per Arne Vollan.

Use more specific mach services for media features on platforms that support them.
This will allow us to narrow the scope to only those endpoints required for
web-related media tasks.

No change in behavior.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/257653@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/iOS-Use-finer-grained-media-services-when-available branch from cfd16b9 to 6cbeaff Compare December 10, 2022 00:12
@webkit-early-warning-system webkit-early-warning-system merged commit 6cbeaff into WebKit:main Dec 10, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257653@main (6cbeaff): https://commits.webkit.org/257653@main

Reviewed commits have been landed. Closing PR #7397 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvollan pvollan pvollan approved these changes

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@brentfulgham @webkit-early-warning-system @webkit-commit-queue @pvollan