Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit integration: configure gitreview.username from ssh://user@gerrit... push-URL / provide way to set username from UI #10596

Closed
cloph opened this issue Dec 12, 2023 · 4 comments · Fixed by #11585
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone

Comments

@cloph
Copy link

cloph commented Dec 12, 2023

Describe the problem

gerrit integration ignores the username provided in push-URL and instead uses the system user's name, at least in the presence of a .gitreview file specifying host, port, project and branch but omitting a username.

That then obviously fails due to lack of permissions and git-review used by weblate asks for a username to try again (and since it is run non-interactive mode it only gets EOF)

Describe the solution you'd like

Weblate should set up gitreview.username configuration when setting up a component/new repository. Either by adding a dedicated input field in the VCS settings, or more straightforward reading it from the pushurl if in ssh://user@..... format

Describe alternatives you've considered

Alternatively it can be solved by telling the user in documentation to manually set the git config in the data/vcs... clone

Screenshots

No response

Additional context

No response

@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Dec 13, 2023
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@nijel
Copy link
Member

nijel commented Dec 13, 2023

This should be pretty easy to implement by customizing configure_remote in the GitWithGerritRepository class.

@harriebird
Copy link
Collaborator

Hi guys, check my PR #11585 for this issue.

@nijel nijel linked a pull request May 13, 2024 that will close this issue
5 tasks
@nijel nijel added this to the 5.6 milestone May 13, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants