Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android plurals with same name as string #1108

Open
nijel opened this issue May 11, 2016 · 0 comments
Open

Support Android plurals with same name as string #1108

nijel opened this issue May 11, 2016 · 0 comments
Labels
bug Something is broken. translate-toolkit Issues which need to be fixed in the translate-toolkit

Comments

@nijel
Copy link
Member

nijel commented May 11, 2016

It's perfectly valid to have string with same name as plural, for example:

    <string name="monthly">Monthly</string>
    <plurals name="monthly">
        <item quantity="one">Monthly %2$s</item>
        <item quantity="other">Every %1$d months %2$s</item>
    </plurals>

However Weblate currently uses only name to identify the strings, so they appear as duplicate ones to Weblate.

To fix this, we probably have to construct internal ID for these strings differently. This change will cause problems to existing translations as they will have to be imported again to get new IDs...

See http://developer.android.com/guide/topics/resources/string-resource.html

@nijel nijel added the bug Something is broken. label May 11, 2016
@nijel nijel added the translate-toolkit Issues which need to be fixed in the translate-toolkit label Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken. translate-toolkit Issues which need to be fixed in the translate-toolkit
Projects
None yet
Development

No branches or pull requests

1 participant