Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check "Mismatched full stop" gives false positive in Russian #11838

Open
2 tasks done
emmapeel2 opened this issue Jun 12, 2024 · 2 comments
Open
2 tasks done

Check "Mismatched full stop" gives false positive in Russian #11838

emmapeel2 opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed. undecided These features might not be implemented. Can be prioritized by sponsorship.

Comments

@emmapeel2
Copy link
Contributor

Describe the issue

Apparently you do not add a full stop after an ellipsis in Russian, so we should refine the check.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

You can see an example string at https://hosted.weblate.org/translate/tor/tor-browser/tor-browser-user-manual/ru/?checksum=edf1c3c8f1716ac2 .

In Russian it is not needed to add that period.

Expected behavior

The 'Mismatched full stop' check should be adapted to this Russian grammar rule, and not get mad because there is no period on the translation.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Jun 13, 2024

I have no clue about the rules in Russian about full stops and quotes, but I'm pretty sure that the referenced string doesn't use correct Russian quotes. That makes me unsure whether the author knows enough about Russian interpunction in other regards. Therefore, I'd like to see some reference that omitting stop is actually correct in this case before adjusting the check accordingly.

PS: In this particular case, the English string is wrong because the label is actually "Configure Connection…" and not "Configure Connection".

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Jun 13, 2024
Copy link

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@nijel nijel added the help wanted Extra attention is needed. label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. help wanted Extra attention is needed. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

No branches or pull requests

2 participants