Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite search caching to allow sharing search links [$15 awarded] #1412

Closed
nijel opened this issue Mar 17, 2017 · 0 comments
Closed

Rewrite search caching to allow sharing search links [$15 awarded] #1412

nijel opened this issue Mar 17, 2017 · 0 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Mar 17, 2017

Currently the search results are cached and after this the URL is not longer shareable. This is quite unpleasant for users which sometimes send links to show particular translation.

The caching has to stay in order to have consistent view when translating (once you filter not translated strings, you want to be able to navigate through it even if you have translated something meanwhile).

Currently it works:

  • If the URL contains search_id, it is directly fetched from session cache and used.
  • If the URL contains search parameters, new search is performed and stored in session cache, further only the search_id is used in the URLs.

We can most likely identify the session cache directly by parameters thus avoid need to exposing some internals in the URL.

@nijel nijel added enhancement Adding or requesting a new feature. refactoring labels Mar 17, 2017
@nijel nijel changed the title Rewrite search caching to allow sharing search links Rewrite search caching to allow sharing search links [$15] Mar 17, 2017
@nijel nijel added the bounty label Mar 17, 2017
@nijel nijel added this to the 2.14 milestone Apr 12, 2017
@nijel nijel self-assigned this May 10, 2017
@nijel nijel closed this as completed in 170b9ba May 10, 2017
@nijel nijel changed the title Rewrite search caching to allow sharing search links [$15] Rewrite search caching to allow sharing search links [$15 awarded] Mar 5, 2018
@nijel nijel changed the title Rewrite search caching to allow sharing search links [$15 awarded] Rewrite search caching to allow sharing search links May 3, 2018
@nijel nijel changed the title Rewrite search caching to allow sharing search links Rewrite search caching to allow sharing search links [$15 awarded] May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant