Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion rejection reason: possibility of explaining why you reject a suggestion #1661

Closed
emmapeel2 opened this issue Oct 16, 2017 · 5 comments
Assignees
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Milestone

Comments

@emmapeel2
Copy link
Contributor

emmapeel2 commented Oct 16, 2017

Steps to reproduce

  1. Review Suggestions from other users
  2. Vote agaisnt or delete suggestion

Expected behaviour

It would be nice to have a text area to add a reason for the downvote-deletion, for the new translators to learn from the reviewers and get better with time.

@nijel
Copy link
Member

nijel commented Oct 16, 2017

How is this different from #1604? :-)

@emmapeel2
Copy link
Contributor Author

Well, I see #1604 only for a comment, not an action. Just comments on the suggestion until the translators decide something.
This one is a reason for an action.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Jan 12, 2018
@comradekingu
Copy link
Contributor

If the suggestion is made without a username, I think the comment on the suggestion should time out, so as not to pollute the fields with old stuff, possibly marketing spam.

@nijel
Copy link
Member

nijel commented May 21, 2019

The cleanup be toggled per project by installing Remove old suggestions or globally by SUGGESTION_CLEANUP_DAYS. But that's a bit offtopic here.

@emmapeel2
Copy link
Contributor Author

emmapeel2 commented Feb 14, 2020

Another thing that I wanted to add is that I want to correct the new contributor in private, for example if they copy an IMG tag without translating the alt attribute, I want to delete the suggestion, adding a reason.
So the new translator will see a message that says:

your suggestion :

here some diff of the suggestion, link, etc.

has been deleted because:

'you need to translate the alt attribute as well' (the reason i gave during deletion)

without shaming the new translator forever in public with a comment on the string.

a bit like it is done in the mailman interface when you can give a reason for discarding or rejecting an email.

@nijel nijel added this to the 4.18 milestone Apr 13, 2023
@nijel nijel self-assigned this Apr 25, 2023
@nijel nijel closed this as completed in 6d503c0 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

No branches or pull requests

3 participants