Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis issues do not link to content #2106

Closed
comradekingu opened this issue Jun 27, 2018 · 8 comments · Fixed by #8014
Closed

Analysis issues do not link to content #2106

comradekingu opened this issue Jun 27, 2018 · 8 comments · Fixed by #8014
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors.
Milestone

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Jun 27, 2018

This is the e-mail I got about QR Code Generator/Translations
"
'Expecting property name enclosed in double quotes: line 2 column 3 (char 4)'

Erroneous file

src/_locales/en/messages.json"

Would expect link to source and respective Weblate section here.

@nijel
Copy link
Member

nijel commented Jun 27, 2018

In this case Weblate failed to parse the file, so the content is not in Weblate and it has to be fixed in the VCS directly. Suggestions to improve the mail are of course welcome.

@comradekingu
Copy link
Contributor Author

comradekingu commented Jun 27, 2018

@nijel I was thinking the e-mail could link to the file in the VCS.
Which in this case is "https://github.com/rugk/offline-qr-code/blob/master/src/_locales/en/messages.json"

It could quote what the offending property name is.

@nijel nijel added the enhancement Adding or requesting a new feature. label Jun 27, 2018
@nijel
Copy link
Member

nijel commented Jun 27, 2018

Unfortunately there is no detailed information from the parser, so this is best error message we can provide.

Link to the VCS should be doable if project has set repository web browser, what is unfortunately not the case for most non Gettext projects...

@nijel
Copy link
Member

nijel commented Jul 14, 2022

Link to the file should be easy to add since 4b2e079 does this in the UI.

@github-actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@ParthS007
Copy link
Member

After going through the mentioned commit and the code, I found that, here => https://github.com/WeblateOrg/weblate/blob/main/weblate/templates/mail/parse_error.html, we parse the error and send it in the mail.

I made some changes in the template to test but I am not able to reproduce the issue. Can you please point me to the views code or where the mail is using this template? Thanks

@nijel
Copy link
Member

nijel commented Jul 17, 2022

This is triggered in case the file in the repository cannot be parsed.

In the debug mode, you can also render individual change events directly without going through e-mail when browsing history by clicking on the bell icon.

@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel added this to the 4.14 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants