Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable punctuation checks for Lojban #2286

Closed
ghost opened this issue Oct 2, 2018 · 4 comments
Closed

Disable punctuation checks for Lojban #2286

ghost opened this issue Oct 2, 2018 · 4 comments
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone

Comments

@ghost
Copy link

ghost commented Oct 2, 2018

Lojban (ISO 639-3 code jbo) does not use the punctuation marks !, ?, :, or . It does use the character ., but not to indicate the end of a sentence. For this reason, the following checks should be disabled for Lojban:

  • EndStopCheck
  • EndColonCheck
  • EndQuestionCheck
  • EndExclamationCheck
  • EndEllipsisCheck

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Oct 3, 2018
@nijel
Copy link
Member

nijel commented Oct 3, 2018

It's easy to add per language exceptions, there are already some:

# Thai does not have a full stop
if self.is_language(unit, ('th', )):
return False

@gchan1
Copy link

gchan1 commented Oct 3, 2018

Hey! I would like to try to take this issue :)

@nijel
Copy link
Member

nijel commented Oct 5, 2018

You're welcome, feel free to ask if you have any questions :-)

@nijel nijel added this to the 3.3 milestone Nov 9, 2018
@nijel nijel self-assigned this Nov 9, 2018
@nijel nijel closed this as completed in 4157819 Nov 9, 2018
@nijel
Copy link
Member

nijel commented Nov 9, 2018

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

2 participants